From: Takashi Iwai <tiwai@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
Petr Vorel <pvorel@suse.cz>, Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/5] exfat: Downgrade ENAMETOOLONG error message to debug messages
Date: Tue, 26 Jul 2022 10:39:28 +0200 [thread overview]
Message-ID: <20220726083929.1684-5-tiwai@suse.de> (raw)
In-Reply-To: <20220726083929.1684-1-tiwai@suse.de>
The ENAMETOOLONG error message is printed at each time when user tries
to operate with a too long name, and this can flood the kernel logs
easily, as every user can trigger this. Let's downgrade this error
message level to a debug message for suppressing the superfluous
logs.
BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1201725
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
fs/exfat/nls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/exfat/nls.c b/fs/exfat/nls.c
index ef115e673406..617aa1272265 100644
--- a/fs/exfat/nls.c
+++ b/fs/exfat/nls.c
@@ -509,7 +509,7 @@ static int exfat_utf8_to_utf16(struct super_block *sb,
}
if (unilen > MAX_NAME_LENGTH) {
- exfat_err(sb, "failed to %s (estr:ENAMETOOLONG) nls len : %d, unilen : %d > %d",
+ exfat_debug(sb, "failed to %s (estr:ENAMETOOLONG) nls len : %d, unilen : %d > %d",
__func__, len, unilen, MAX_NAME_LENGTH);
return -ENAMETOOLONG;
}
--
2.35.3
next prev parent reply other threads:[~2022-07-26 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 8:39 [PATCH v2 0/5] exfat: Fixes for ENAMETOOLONG error handling Takashi Iwai
2022-07-26 8:39 ` [PATCH v2 1/5] exfat: Return ENAMETOOLONG consistently for oversized paths Takashi Iwai
2022-07-26 8:39 ` [PATCH v2 2/5] exfat: Define NLS_NAME_* as bit flags explicitly Takashi Iwai
2022-07-26 8:39 ` [PATCH v2 3/5] exfat: Expand exfat_err() and co directly to pr_*() macro Takashi Iwai
2022-07-26 8:39 ` Takashi Iwai [this message]
2022-07-26 8:39 ` [PATCH v2 5/5] exfat: Drop superfluous new line for error messages Takashi Iwai
2022-07-29 3:08 ` [PATCH v2 0/5] exfat: Fixes for ENAMETOOLONG error handling Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726083929.1684-5-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=joe@perches.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).