From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v2 2/2] fsverity: stop using PG_error to track error status
Date: Fri, 28 Oct 2022 10:48:11 -0700 [thread overview]
Message-ID: <Y1wV248oIKJX0kCy@sol.localdomain> (raw)
In-Reply-To: <47a86f09-3e9b-f841-4191-d750feda6642@kernel.org>
On Tue, Sep 06, 2022 at 11:43:47PM +0800, Chao Yu wrote:
> > @@ -1768,6 +1745,8 @@ static void f2fs_verify_cluster(struct work_struct *work)
> > void f2fs_decompress_end_io(struct decompress_io_ctx *dic, bool failed,
> > bool in_task)
> > {
> > + int i;
> > +
> > if (!failed && dic->need_verity) {
> > /*
> > * Note that to avoid deadlocks, the verity work can't be done
> > @@ -1777,9 +1756,28 @@ void f2fs_decompress_end_io(struct decompress_io_ctx *dic, bool failed,
> > */
> > INIT_WORK(&dic->verity_work, f2fs_verify_cluster);
> > fsverity_enqueue_verify_work(&dic->verity_work);
> > - } else {
> > - __f2fs_decompress_end_io(dic, failed, in_task);
>
> Will it be possible to clean up __f2fs_decompress_end_io() and
> f2fs_verify_cluster(), they looks almost similar...
>
I feel that it's simpler to keep them separate.
> > +static void f2fs_finish_read_bio(struct bio *bio, bool in_task,
> > + bool fail_compressed)
>
> Not sure, fail_decompress or fail_decompression may looks more readable?
>
I'll add a field 'bool decompression_attempted' to struct bio_post_read_ctx so
that this extra argument won't be needed.
- Eric
next prev parent reply other threads:[~2022-10-28 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 23:50 [PATCH v2 0/2] ext4, f2fs: stop using PG_error for fscrypt and fsverity Eric Biggers
2022-08-15 23:50 ` [PATCH v2 1/2] fscrypt: stop using PG_error to track error status Eric Biggers
2022-09-06 15:09 ` [f2fs-dev] " Chao Yu
2022-08-15 23:50 ` [PATCH v2 2/2] fsverity: " Eric Biggers
2022-09-06 15:43 ` [f2fs-dev] " Chao Yu
2022-10-28 17:48 ` Eric Biggers [this message]
2022-08-22 18:27 ` [PATCH v2 0/2] ext4, f2fs: stop using PG_error for fscrypt and fsverity Eric Biggers
2022-08-22 19:21 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1wV248oIKJX0kCy@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).