From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Eric Biggers <ebiggers@kernel.org>, linux-fscrypt@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Subject: Re: [PATCH] fscrypt: add additional documentation for SM4 support
Date: Fri, 2 Dec 2022 20:08:16 +0800 [thread overview]
Message-ID: <65e77226-7ba7-5f72-0197-ea4f4fcd774a@linux.alibaba.com> (raw)
In-Reply-To: <20221201191452.6557-1-ebiggers@kernel.org>
Hi Eric,
On 12/2/22 3:14 AM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Add a paragraph about SM4, like there is for the other modes.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> Documentation/filesystems/fscrypt.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/filesystems/fscrypt.rst b/Documentation/filesystems/fscrypt.rst
> index c0784ec055530..ef183387da208 100644
> --- a/Documentation/filesystems/fscrypt.rst
> +++ b/Documentation/filesystems/fscrypt.rst
> @@ -370,6 +370,12 @@ CONFIG_CRYPTO_HCTR2 must be enabled. Also, fast implementations of XCTR and
> POLYVAL should be enabled, e.g. CRYPTO_POLYVAL_ARM64_CE and
> CRYPTO_AES_ARM64_CE_BLK for ARM64.
>
> +SM4 is a Chinese block cipher that is an alternative to AES. It has
> +not seen as much security review as AES, and it only has a 128-bit key
> +size. It may be useful in cases where its use is mandated.
> +Otherwise, it should not be used. For SM4 support to be available, it
> +also needs to be enabled in the kernel crypto API.
> +
Looks good to me, this description is appropriate.
Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Thanks,
Tianjia
> New encryption modes can be added relatively easily, without changes
> to individual filesystems. However, authenticated encryption (AE)
> modes are not currently supported because of the difficulty of dealing
prev parent reply other threads:[~2022-12-02 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 19:14 [PATCH] fscrypt: add additional documentation for SM4 support Eric Biggers
2022-12-02 12:08 ` Tianjia Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65e77226-7ba7-5f72-0197-ea4f4fcd774a@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=ebiggers@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).