From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "Theodore Y. Ts o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
Ard Biesheuvel <ardb@kernel.org>,
Bagas Sanjaya <bagasdotme@gmail.com>,
linux-fscrypt@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v4 0/2] Add SM4 XTS symmetric algorithm for blk-crypto and fscrypt
Date: Fri, 2 Dec 2022 20:01:50 +0800 [thread overview]
Message-ID: <4ac71618-030a-e198-2885-f5f06d8483b3@linux.alibaba.com> (raw)
In-Reply-To: <Y4kAiKhZL4Ucv3MI@sol.localdomain>
Hi Eric,
On 12/2/22 3:29 AM, Eric Biggers wrote:
> On Thu, Dec 01, 2022 at 08:58:17PM +0800, Tianjia Zhang wrote:
>> SM4 is widely used in China's data encryption software and hardware.
>> these algoritms are mandatory in many scenarios. This serial of
>> patches enables the SM4-XTS algorithm in blk-crypto and enables the
>> SM4-XTS/CTS algorithm in fscrypt to encrypt file content and filename.
>>
>> v4 changes:
>> - only allow the SM4 XTS/CTS algorithm in policy v2 for fscrypt
>> - update git commit message
>>
>> v3 change:
>> - update git commit message
>>
>> v2 change:
>> - As Eric said, the new FSCRYPT_MODE is defined for the unused numbers 7 and 8
>>
>> Tianjia Zhang (2):
>> blk-crypto: Add support for SM4-XTS blk crypto mode
>> fscrypt: Add SM4 XTS/CTS symmetric algorithm support
>>
>> Documentation/filesystems/fscrypt.rst | 1 +
>> block/blk-crypto.c | 6 ++++++
>> fs/crypto/keysetup.c | 15 +++++++++++++++
>> fs/crypto/policy.c | 5 +++++
>> include/linux/blk-crypto.h | 1 +
>> include/uapi/linux/fscrypt.h | 2 ++
>> 6 files changed, 30 insertions(+)
>
> Applied. I don't think anyone should actually use this, but with the SM*
> algorithms turning up everywhere these days, and people seemingly being totally
> okay with that for some reason, I don't think it's fair for me to reject this.
>
> - Eric
Thanks, this is really frustrating, still very grateful for your advice
and review.
Best regards,
Tianjia
prev parent reply other threads:[~2022-12-02 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 12:58 [PATCH v4 0/2] Add SM4 XTS symmetric algorithm for blk-crypto and fscrypt Tianjia Zhang
2022-12-01 12:58 ` [PATCH v4 1/2] blk-crypto: Add support for SM4-XTS blk crypto mode Tianjia Zhang
2022-12-01 12:58 ` [PATCH v4 2/2] fscrypt: Add SM4 XTS/CTS symmetric algorithm support Tianjia Zhang
2022-12-01 19:29 ` [PATCH v4 0/2] Add SM4 XTS symmetric algorithm for blk-crypto and fscrypt Eric Biggers
2022-12-02 12:01 ` Tianjia Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ac71618-030a-e198-2885-f5f06d8483b3@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=ardb@kernel.org \
--cc=axboe@kernel.dk \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).