From: Zorro Lang <zlang@redhat.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH v3 00/10] xfstests: update verity tests for non-4K block and page size
Date: Sun, 1 Jan 2023 21:30:32 +0800 [thread overview]
Message-ID: <20230101133032.6jz4dvd6wx5m3ws5@zlang-mailbox> (raw)
In-Reply-To: <20221229233222.119630-1-ebiggers@kernel.org>
On Thu, Dec 29, 2022 at 03:32:12PM -0800, Eric Biggers wrote:
> This series updates the verity xfstests to eliminate implicit
> assumptions that 'merkle_tree_block_size == fs_block_size == page_size
> == 4096', and to provide some test coverage for cases where
> merkle_tree_block_size differs from fs_block_size and/or page_size. It
> doesn't add any new test scripts, but it does update some of the
> existing test scripts to test multiple block sizes.
>
> This goes along with my kernel patch series
> "fsverity: support for non-4K pages"
> (https://lore.kernel.org/linux-fsdevel/20221223203638.41293-1-ebiggers@kernel.org/T/#u).
> However, it's not necessary to wait for that kernel patch series to be
> applied before applying this xfstests patch series.
>
> Changed in v3:
> - Fixed generic/574 failure with some bash versions.
Thanks for fixing this failure, this version looks good to me. I'd like to
merge this patchset with my RVB.
>
> Changed in v2:
> - Adjusted the output of generic/574, generic/575, and generic/624
> slightly to avoid confusion.
>
> Eric Biggers (10):
> common/verity: add and use _fsv_can_enable()
> common/verity: set FSV_BLOCK_SIZE to an appropriate value
> common/verity: use FSV_BLOCK_SIZE by default
> common/verity: add _filter_fsverity_digest()
> generic/572: support non-4K Merkle tree block size
> generic/573: support non-4K Merkle tree block size
> generic/577: support non-4K Merkle tree block size
> generic/574: test multiple Merkle tree block sizes
> generic/624: test multiple Merkle tree block sizes
> generic/575: test 1K Merkle tree block size
>
> common/verity | 84 ++++++++++++----
> tests/generic/572 | 21 ++--
> tests/generic/572.out | 10 +-
> tests/generic/573 | 8 +-
> tests/generic/574 | 219 +++++++++++++++++++++++++-----------------
> tests/generic/574.out | 83 +---------------
> tests/generic/575 | 57 ++++++++---
> tests/generic/575.out | 8 +-
> tests/generic/577 | 24 ++---
> tests/generic/577.out | 10 +-
> tests/generic/624 | 119 ++++++++++++++++-------
> tests/generic/624.out | 15 +--
> 12 files changed, 370 insertions(+), 288 deletions(-)
>
>
> base-commit: 3dc46f477b39d732e1841e6f5a180759cee3e8ce
> --
> 2.39.0
>
prev parent reply other threads:[~2023-01-01 13:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 23:32 [PATCH v3 00/10] xfstests: update verity tests for non-4K block and page size Eric Biggers
2022-12-29 23:32 ` [PATCH v3 01/10] common/verity: add and use _fsv_can_enable() Eric Biggers
2022-12-29 23:32 ` [PATCH v3 02/10] common/verity: set FSV_BLOCK_SIZE to an appropriate value Eric Biggers
2022-12-29 23:32 ` [PATCH v3 03/10] common/verity: use FSV_BLOCK_SIZE by default Eric Biggers
2022-12-29 23:32 ` [PATCH v3 04/10] common/verity: add _filter_fsverity_digest() Eric Biggers
2022-12-29 23:32 ` [PATCH v3 05/10] generic/572: support non-4K Merkle tree block size Eric Biggers
2022-12-29 23:32 ` [PATCH v3 06/10] generic/573: " Eric Biggers
2022-12-29 23:32 ` [PATCH v3 07/10] generic/577: " Eric Biggers
2022-12-29 23:32 ` [PATCH v3 08/10] generic/574: test multiple Merkle tree block sizes Eric Biggers
2022-12-29 23:32 ` [PATCH v3 09/10] generic/624: " Eric Biggers
2022-12-29 23:32 ` [PATCH v3 10/10] generic/575: test 1K Merkle tree block size Eric Biggers
2023-01-01 13:30 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230101133032.6jz4dvd6wx5m3ws5@zlang-mailbox \
--to=zlang@redhat.com \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).