From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH v4 0/3] fscrypt: rework keyring and stop using request_queue
Date: Thu, 1 Sep 2022 12:32:05 -0700 [thread overview]
Message-ID: <20220901193208.138056-1-ebiggers@kernel.org> (raw)
Patch 1 of this series reworks the fscrypt filesystem-level keyring to
not use the keyrings subsystem as part of its internal implementation
(except for ->mk_users, which remains unchanged for now). This fixes
several issues, described in the patch itself. This is also a
prerequisite for eliminating the direct use of struct request_queue from
filesystem code, as discussed at
https://lore.kernel.org/linux-fscrypt/20220721125929.1866403-1-hch@lst.de/T/#u
Patches 2-3 eliminate the direct uses of struct request_queue from
fs/crypto/ that don't require block layer changes. (The remaining uses
will be eliminated later by changing some of the blk-crypto functions.)
Changed in v4:
- Restored a NULL check in fscrypt_destroy_inline_crypt_key() that
I had accidentally dropped.
- Tweaked patches 2 and 3 slightly so that patch 2 no longer makes
as many changes that patch 3 then undoes.
Changed in v3:
- Added patch "fscrypt: work on block_devices instead of request_queues"
Changed in v2:
- Don't compare uninitialized bytes of struct fscrypt_key_specifier
- Don't use refcount_dec_and_lock() unnecessarily
- Other minor cleanups
Christoph Hellwig (1):
fscrypt: work on block_devices instead of request_queues
Eric Biggers (2):
fscrypt: stop using keyrings subsystem for fscrypt_master_key
fscrypt: stop holding extra request_queue references
fs/crypto/fscrypt_private.h | 74 ++++--
fs/crypto/hooks.c | 10 +-
fs/crypto/inline_crypt.c | 147 ++++++-----
fs/crypto/keyring.c | 495 +++++++++++++++++++-----------------
fs/crypto/keysetup.c | 89 +++----
fs/crypto/keysetup_v1.c | 4 +-
fs/crypto/policy.c | 8 +-
fs/f2fs/super.c | 24 +-
fs/super.c | 2 +-
include/linux/fs.h | 2 +-
include/linux/fscrypt.h | 25 +-
11 files changed, 462 insertions(+), 418 deletions(-)
base-commit: 1c23f9e627a7b412978b4e852793c5e3c3efc555
--
2.37.2
next reply other threads:[~2022-09-01 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 19:32 Eric Biggers [this message]
2022-09-01 19:32 ` [PATCH v4 1/3] fscrypt: stop using keyrings subsystem for fscrypt_master_key Eric Biggers
2022-09-01 19:32 ` [PATCH v4 2/3] fscrypt: stop holding extra request_queue references Eric Biggers
2022-09-01 19:32 ` [PATCH v4 3/3] fscrypt: work on block_devices instead of request_queues Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901193208.138056-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).