From: Michal Simek <michal.simek@amd.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-crypto@vger.kernel.org
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] fpga: zynq-fpga: use 'time_left' variable with wait_for_completion_timeout()
Date: Mon, 6 May 2024 10:08:45 +0200 [thread overview]
Message-ID: <fcff2634-21ba-4fe8-bb96-2c097adb0656@amd.com> (raw)
In-Reply-To: <20240502210038.11480-3-wsa+renesas@sang-engineering.com>
On 5/2/24 23:00, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_completion_timeout() causing patterns like:
>
> timeout = wait_for_completion_timeout(...)
> if (!timeout) return -ETIMEDOUT;
>
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/fpga/zynq-fpga.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 0ac93183d201..4db3d80e10b0 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -387,7 +387,7 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, struct sg_table *sgt)
> const char *why;
> int err;
> u32 intr_status;
> - unsigned long timeout;
> + unsigned long time_left;
> unsigned long flags;
> struct scatterlist *sg;
> int i;
> @@ -427,8 +427,8 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, struct sg_table *sgt)
> zynq_step_dma(priv);
> spin_unlock_irqrestore(&priv->dma_lock, flags);
>
> - timeout = wait_for_completion_timeout(&priv->dma_done,
> - msecs_to_jiffies(DMA_TIMEOUT_MS));
> + time_left = wait_for_completion_timeout(&priv->dma_done,
> + msecs_to_jiffies(DMA_TIMEOUT_MS));
>
> spin_lock_irqsave(&priv->dma_lock, flags);
> zynq_fpga_set_irq(priv, 0);
> @@ -452,7 +452,7 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, struct sg_table *sgt)
>
> if (priv->cur_sg ||
> !((intr_status & IXR_D_P_DONE_MASK) == IXR_D_P_DONE_MASK)) {
> - if (timeout == 0)
> + if (time_left == 0)
> why = "DMA timed out";
> else
> why = "DMA did not complete";
Acked-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
prev parent reply other threads:[~2024-05-06 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:00 [PATCH 0/2] fpga: use 'time_left' instead of 'timeout' with wait_for_*() functions Wolfram Sang
2024-05-02 21:00 ` [PATCH 1/2] fpga: socfpga: use 'time_left' variable with wait_for_completion_interruptible_timeout() Wolfram Sang
2024-05-02 21:00 ` [PATCH 2/2] fpga: zynq-fpga: use 'time_left' variable with wait_for_completion_timeout() Wolfram Sang
2024-05-06 8:08 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcff2634-21ba-4fe8-bb96-2c097adb0656@amd.com \
--to=michal.simek@amd.com \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).