From: "Colberg, Peter" <peter.colberg@intel.com>
To: "yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>
Cc: "Xu, Yilun" <yilun.xu@intel.com>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"mdf@kernel.org" <mdf@kernel.org>, "Wu, Hao" <hao.wu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"russ.weight@linux.dev" <russ.weight@linux.dev>,
"Pagani, Marco" <marpagan@redhat.com>,
"Rix, Tom" <trix@redhat.com>,
"matthew.gerlach@linux.intel.com"
<matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH] fpga: dfl: afu: remove unused member pdata from struct dfl_afu
Date: Mon, 1 Apr 2024 18:27:08 +0000 [thread overview]
Message-ID: <df3382349cbb72fc1604d3e305edbad9e81505a4.camel@intel.com> (raw)
In-Reply-To: <ZgrLZCl1nPDMcq/i@yilunxu-OptiPlex-7050>
On Mon, 2024-04-01 at 22:57 +0800, Xu Yilun wrote:
> On Thu, Mar 28, 2024 at 07:54:17PM -0400, Peter Colberg wrote:
> > The member pdata was added to struct dfl_afu in commit 857a26222ff7
> > ("fpga: dfl: afu: add afu sub feature support") and is set in function
> > afu_dev_init() but otherwise never used.
>
> Could you also help check if dfl_fme has the same issue?
Indeed, thank you for pointing this out.
Peter
>
> Thanks,
> Yilun
>
> >
> > Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> > Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > ---
> > drivers/fpga/dfl-afu-main.c | 2 --
> > drivers/fpga/dfl-afu.h | 3 ---
> > 2 files changed, 5 deletions(-)
> >
> > diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c
> > index c0a75ca360d6..6b97c073849e 100644
> > --- a/drivers/fpga/dfl-afu-main.c
> > +++ b/drivers/fpga/dfl-afu-main.c
> > @@ -858,8 +858,6 @@ static int afu_dev_init(struct platform_device *pdev)
> > if (!afu)
> > return -ENOMEM;
> >
> > - afu->pdata = pdata;
> > -
> > mutex_lock(&pdata->lock);
> > dfl_fpga_pdata_set_private(pdata, afu);
> > afu_mmio_region_init(pdata);
> > diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h
> > index 674e9772f0ea..7bef3e300aa2 100644
> > --- a/drivers/fpga/dfl-afu.h
> > +++ b/drivers/fpga/dfl-afu.h
> > @@ -67,7 +67,6 @@ struct dfl_afu_dma_region {
> > * @regions: the mmio region linked list of this afu feature device.
> > * @dma_regions: root of dma regions rb tree.
> > * @num_umsgs: num of umsgs.
> > - * @pdata: afu platform device's pdata.
> > */
> > struct dfl_afu {
> > u64 region_cur_offset;
> > @@ -75,8 +74,6 @@ struct dfl_afu {
> > u8 num_umsgs;
> > struct list_head regions;
> > struct rb_root dma_regions;
> > -
> > - struct dfl_feature_platform_data *pdata;
> > };
> >
> > /* hold pdata->lock when call __afu_port_enable/disable */
> > --
> > 2.44.0
> >
> >
prev parent reply other threads:[~2024-04-01 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 23:54 [PATCH] fpga: dfl: afu: remove unused member pdata from struct dfl_afu Peter Colberg
2024-04-01 14:57 ` Xu Yilun
2024-04-01 18:27 ` Colberg, Peter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df3382349cbb72fc1604d3e305edbad9e81505a4.camel@intel.com \
--to=peter.colberg@intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=russ.weight@linux.dev \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).