From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>, Conor Dooley <conor@kernel.org>
Cc: Animesh Agarwal <animeshagarwal28@gmail.com>,
mdf@kernel.org, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: altera-fpga2sdram-bridge: Convert to dtschema
Date: Wed, 6 Mar 2024 09:21:28 +0100 [thread overview]
Message-ID: <ae3f9ef0-8e51-4c0f-9b60-c6dfebb1ab0c@linaro.org> (raw)
In-Reply-To: <20240304170759.GA752387-robh@kernel.org>
On 04/03/2024 18:07, Rob Herring wrote:
>>> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
>>> new file mode 100644
>>> index 000000000000..88bf9e3151b6
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
>>> @@ -0,0 +1,23 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/fpga/altr-fpga2sdram-bridge.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Altera FPGA To SDRAM Bridge Driver
>
> Bindings are for h/w blocks, not Drivers.
>
>>> +
>>
>> You're missing maintainers: (shouldn't dt_binding_check complain?)
>
> Yes. Patchwork says this failed to apply which is odd because it is
> doubtful that altera-fpga2sdram-bridge.txt has been modified.
The file was already converted by Michal, two months ago!
Animesh,
Please (almost) always work on current next. Also, before doing
conversion check if there is such work on the lists ("dfn:" on
lore.kernel.org).
It's waste of your and ours (three maintainers...) time, since this was
already done two months ago.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-03-06 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 16:16 [PATCH] dt-bindings: altera-fpga2sdram-bridge: Convert to dtschema Animesh Agarwal
2024-03-01 16:23 ` Conor Dooley
2024-03-04 17:07 ` Rob Herring
2024-03-06 8:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae3f9ef0-8e51-4c0f-9b60-c6dfebb1ab0c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=animeshagarwal28@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=robh@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).