From: Xu Yilun <yilun.xu@linux.intel.com>
To: Peter Colberg <peter.colberg@intel.com>
Cc: Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
Russ Weight <russ.weight@linux.dev>,
Marco Pagani <marpagan@redhat.com>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH v2] fpga: dfl: remove unused member pdata from struct dfl_{afu,fme}
Date: Sat, 13 Apr 2024 11:30:54 +0800 [thread overview]
Message-ID: <Zhn8bjex94DpkGBw@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <Zhn3npCOy2h1SYm4@yilunxu-OptiPlex-7050>
On Sat, Apr 13, 2024 at 11:10:22AM +0800, Xu Yilun wrote:
> On Mon, Apr 01, 2024 at 02:49:15PM -0400, Peter Colberg wrote:
> > The member pdata was added to struct dfl_afu in commit 857a26222ff7 ("fpga:
> > dfl: afu: add afu sub feature support") and to struct dfl_fme in commit
Sorry, I didn't apply. Please don't wrap the git commit description. Put
them in a new line but no wrap, if you have to reference git commit in
changelog.
> > 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature
> > support").
This sentence is actually not useful, I suggest you just remove it and
add a Fix: tag below. That makes reviewers quickly find what the
problem. Also avoid the git commit references fragments the changelog
too much.
Thanks,
Yilun
> > It is set in function {afu,fme}_dev_init() but never used.
> >
> > Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> > Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> Acked-by: Xu Yilun <yilun.xu@intel.com>
>
> Applied to for-next.
>
prev parent reply other threads:[~2024-04-13 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 18:49 [PATCH v2] fpga: dfl: remove unused member pdata from struct dfl_{afu,fme} Peter Colberg
2024-04-13 3:10 ` Xu Yilun
2024-04-13 3:30 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zhn8bjex94DpkGBw@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=peter.colberg@intel.com \
--cc=russ.weight@linux.dev \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).