From: Xu Yilun <yilun.xu@linux.intel.com>
To: Peter Colberg <peter.colberg@intel.com>
Cc: Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
Russ Weight <russ.weight@linux.dev>,
Marco Pagani <marpagan@redhat.com>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH] fpga: dfl: remove unused function is_dfl_feature_present
Date: Sat, 13 Apr 2024 11:39:00 +0800 [thread overview]
Message-ID: <Zhn+VHyaD9rZ0X/w@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20240402222038.1438718-1-peter.colberg@intel.com>
On Tue, Apr 02, 2024 at 06:20:38PM -0400, Peter Colberg wrote:
> The function is_dfl_feature_present was added in commit 5b57d02a2f94
> ("fpga: dfl: add feature device infrastructure") but never used.
Same git commit reference problem, please see:
https://lore.kernel.org/all/Zhn8bjex94DpkGBw@yilunxu-OptiPlex-7050/
Thanks,
Yilun
>
> Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> ---
> drivers/fpga/dfl.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 1d724a28f00a..5063d73b0d82 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
> return NULL;
> }
>
> -static inline bool is_dfl_feature_present(struct device *dev, u16 id)
> -{
> - return !!dfl_get_feature_ioaddr_by_id(dev, id);
> -}
> -
> static inline
> struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
> {
> --
> 2.44.0
>
>
prev parent reply other threads:[~2024-04-13 3:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 22:20 [PATCH] fpga: dfl: remove unused function is_dfl_feature_present Peter Colberg
2024-04-13 3:39 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zhn+VHyaD9rZ0X/w@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=peter.colberg@intel.com \
--cc=russ.weight@linux.dev \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).