From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v1 1/1] fpga: ice40-spi: Remove redundant of_match_ptr() macros
Date: Mon, 15 Apr 2024 16:21:30 +0300 [thread overview]
Message-ID: <Zh0p2vzG6h8M7Xpd@smile.fi.intel.com> (raw)
In-Reply-To: <Zhn0SgGulHq8Bbk3@yilunxu-OptiPlex-7050>
On Sat, Apr 13, 2024 at 10:56:10AM +0800, Xu Yilun wrote:
> On Fri, Apr 12, 2024 at 06:58:30PM +0300, Andy Shevchenko wrote:
> > Since the driver hi6421-regulator depends on CONFIG_OF,
> ^
> It is ice40-spi
Oops, copy-and-paste typo.
> > it makes no difference to wrap of_match_ptr() here.
> >
> > Remove of_match_ptr() macros to clean it up.
> >
> > While at it, add missing mod_devicetable.h.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Closes: https://lore.kernel.org/r/20240412151147.22a059ff@canb.auug.org.au
> > Fixes: 5d04660b29fb ("fpga: ice40-spi: Remove unused of_gpio.h")
>
> Since 5d04660b29fb is not merged yet, could you just merge them into one?
> Or it breaks bisecting.
You can also fold it, but sure, I'll send a v2.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-15 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 15:58 [PATCH v1 1/1] fpga: ice40-spi: Remove redundant of_match_ptr() macros Andy Shevchenko
2024-04-13 2:56 ` Xu Yilun
2024-04-15 13:21 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh0p2vzG6h8M7Xpd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).