From: Xu Yilun <yilun.xu@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH] fpga: altera-cvp: Remove an unused field in struct altera_cvp_conf
Date: Tue, 2 Apr 2024 14:30:57 +0800 [thread overview]
Message-ID: <ZgumIQV3fUpxNqno@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <7986690e79fa6f7880bc1db783cb0e46a1c2723e.1711976883.git.christophe.jaillet@wanadoo.fr>
On Mon, Apr 01, 2024 at 03:08:21PM +0200, Christophe JAILLET wrote:
> In "struct altera_cvp_conf", the 'mgr' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-next.
> ---
> Apparently, it has never been used. It is not a left-over from a
> refactoring.
>
> The address of the 'fpga_manager' is handled via pci_[s|g]et_drvdata().
>
> Compile tested only.
> ---
> drivers/fpga/altera-cvp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
> index 4ffb9da537d8..6b0914432445 100644
> --- a/drivers/fpga/altera-cvp.c
> +++ b/drivers/fpga/altera-cvp.c
> @@ -72,7 +72,6 @@ static bool altera_cvp_chkcfg;
> struct cvp_priv;
>
> struct altera_cvp_conf {
> - struct fpga_manager *mgr;
> struct pci_dev *pci_dev;
> void __iomem *map;
> void (*write_data)(struct altera_cvp_conf *conf,
> --
> 2.44.0
>
>
prev parent reply other threads:[~2024-04-02 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 13:08 [PATCH] fpga: altera-cvp: Remove an unused field in struct altera_cvp_conf Christophe JAILLET
2024-04-02 6:30 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgumIQV3fUpxNqno@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hao.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).