From: Xu Yilun <yilun.xu@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Marco Pagani <marpagan@redhat.com>,
Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: disable KUnit test suites when module support is enabled
Date: Fri, 20 Oct 2023 10:38:38 +0800 [thread overview]
Message-ID: <ZTHoLv4Ttvz4++H/@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <2023101924-hunk-conjuror-2d35@gregkh>
On Thu, Oct 19, 2023 at 07:33:08PM +0200, Greg KH wrote:
> On Thu, Oct 19, 2023 at 10:47:39PM +0800, Xu Yilun wrote:
> > On Wed, Oct 18, 2023 at 06:38:13PM +0200, Marco Pagani wrote:
> > > The fpga core currently assumes that all manager, bridge, and region
> > > devices have a parent device associated with a driver that can be used
> > > to take the module's refcount. This behavior causes the fpga test suites
> > > to crash with a null-ptr-deref since parent fake devices do not have a
> > > driver. This patch disables all fpga KUnit test suites when loadable
> > > module support is enabled until the fpga core is fixed. Test suites
> > > can still be run using the KUnit default UML kernel.
> > >
> > > Signed-off-by: Marco Pagani <marpagan@redhat.com>
> >
> > LGTM, I've tested on my machine.
> >
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> >
> > Hi Greg:
> >
> > Could you help review and pull it in for 6.6-final if it's OK.
> >
> > https://lore.kernel.org/linux-fpga/2023101825-ligament-undergrad-cc4d@gregkh/
>
> Needs a "Fixes:" tag please, you can provide it here in this email
> thread and b4 will pick it up automatically for me.
Fixes: ccbc1c302115 ("fpga: add an initial KUnit suite for the FPGA Manager")
Thanks,
Yilun
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2023-10-20 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 16:38 [PATCH] fpga: disable KUnit test suites when module support is enabled Marco Pagani
2023-10-19 14:47 ` Xu Yilun
2023-10-19 17:33 ` Greg KH
2023-10-20 2:38 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTHoLv4Ttvz4++H/@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).