From: Xu Yilun <yilun.xu@intel.com>
To: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: hao.wu@intel.com, trix@redhat.com, mdf@kernel.org,
liwei391@huawei.com, linux-fpga@vger.kernel.org
Subject: Re: [PATCH] fpga: dfl-pci: Use pci_find_vsec_capability() to simplify the code
Date: Mon, 7 Aug 2023 18:25:02 +0800 [thread overview]
Message-ID: <ZNDGfgLX3u4Yrs3k@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20230802080726.178194-1-wangxiongfeng2@huawei.com>
On 2023-08-02 at 16:07:26 +0800, Xiongfeng Wang wrote:
> PCI core add pci_find_vsec_capability() to query VSEC. We can use that
> core API to simplify the code.
>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-next.
Thanks.
> ---
> drivers/fpga/dfl-pci.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> index 1bc04378118c..98b8fd16183e 100644
> --- a/drivers/fpga/dfl-pci.c
> +++ b/drivers/fpga/dfl-pci.c
> @@ -156,19 +156,12 @@ static int *cci_pci_create_irq_table(struct pci_dev *pcidev, unsigned int nvec)
>
> static int find_dfls_by_vsec(struct pci_dev *pcidev, struct dfl_fpga_enum_info *info)
> {
> - u32 bir, offset, vndr_hdr, dfl_cnt, dfl_res;
> - int dfl_res_off, i, bars, voff = 0;
> + u32 bir, offset, dfl_cnt, dfl_res;
> + int dfl_res_off, i, bars, voff;
> resource_size_t start, len;
>
> - while ((voff = pci_find_next_ext_capability(pcidev, voff, PCI_EXT_CAP_ID_VNDR))) {
> - vndr_hdr = 0;
> - pci_read_config_dword(pcidev, voff + PCI_VNDR_HEADER, &vndr_hdr);
> -
> - if (PCI_VNDR_HEADER_ID(vndr_hdr) == PCI_VSEC_ID_INTEL_DFLS &&
> - pcidev->vendor == PCI_VENDOR_ID_INTEL)
> - break;
> - }
> -
> + voff = pci_find_vsec_capability(pcidev, PCI_VENDOR_ID_INTEL,
> + PCI_VSEC_ID_INTEL_DFLS);
> if (!voff) {
> dev_dbg(&pcidev->dev, "%s no DFL VSEC found\n", __func__);
> return -ENODEV;
> --
> 2.20.1
>
prev parent reply other threads:[~2023-08-07 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 8:07 [PATCH] fpga: dfl-pci: Use pci_find_vsec_capability() to simplify the code Xiongfeng Wang
2023-08-07 10:25 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNDGfgLX3u4Yrs3k@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).