From: sangsup lee <k1rh4.lee@gmail.com>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: Xu Yilun <yilun.xu@intel.com>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>, Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: dfl-afu-region: Add overflow checks for region size and offset
Date: Mon, 10 Apr 2023 11:17:01 +0900 [thread overview]
Message-ID: <CAJkuJRh4r9bqjfTAdkFgAQ1Az+zt6HuG85d-fWVQXdgmQDW8dQ@mail.gmail.com> (raw)
In-Reply-To: <ZDMLSOoMt5Ims6xT@eldamar.lan>
Hi,
In my opinion the code has an insecure code pattern.
The size may have integer overflow condition i think.
But, I did not do dynamic analysis but I did static audit fpga code(I
don't have an fpga device).
because of this. I don't make sure about Yilun's comment.
I think the code must have defensive coding rules.
best regards.
prev parent reply other threads:[~2023-04-10 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 5:43 [PATCH] fpga: dfl-afu-region: Add overflow checks for region size and offset k1rh4.lee
2023-02-06 16:50 ` Russ Weight
2023-02-10 8:21 ` Xu Yilun
2023-04-09 19:00 ` Salvatore Bonaccorso
2023-04-10 2:17 ` sangsup lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJkuJRh4r9bqjfTAdkFgAQ1Az+zt6HuG85d-fWVQXdgmQDW8dQ@mail.gmail.com \
--to=k1rh4.lee@gmail.com \
--cc=carnil@debian.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).