From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nava kishore Manne <nava.kishore.manne@amd.com>,
mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com,
trix@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: fpga: xilinx-spi: convert bindings to json-schema
Date: Fri, 24 Feb 2023 15:55:07 +0100 [thread overview]
Message-ID: <2df19bef-5565-6961-3235-bf1ea21eabfe@linaro.org> (raw)
In-Reply-To: <20230224113711.193903-1-nava.kishore.manne@amd.com>
On 24/02/2023 12:37, Nava kishore Manne wrote:
> Convert xilinx-spi bindings to DT schema format using json-schema
Missing full stop.
>
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
> ---
> .../bindings/fpga/xilinx-slave-serial.txt | 51 ------------
> .../bindings/fpga/xlnx,fpga-slave-serial.yaml | 77 +++++++++++++++++++
> 2 files changed, 77 insertions(+), 51 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt
> create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
Thank you for your patch. There is something to discuss/improve.
> +++ b/Documentation/devicetree/bindings/fpga/xlnx,fpga-slave-serial.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/xlnx,fpga-slave-serial.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xilinx Slave Serial SPI FPGA driver.
Drop driver and full stop.
> +
> +maintainers:
> + - Nava kishore Manne <nava.kishore.manne@amd.com>
> +
> +description: |
> + Xilinx Spartan-6 and 7 Series FPGAs support a method of loading the bitstream
> + over what is referred to as slave serial interface.The slave serial link is
> + not technically SPI, and might require extra circuits in order to play nicely
> + with other SPI slaves on the same bus.
> + Please refer to fpga-region.txt in this directory for common binding part
> + and usage.
Just one space, not two. But what exactly from fpga-region comes here?
If it is used, you need to mention it otherwise it's not allowed to be
used...
> +
> + Datasheets:
> + https://www.xilinx.com/support/documentation/user_guides/ug380.pdf
> + https://www.xilinx.com/support/documentation/user_guides/ug470_7Series_Config.pdf
> + https://www.xilinx.com/support/documentation/application_notes/xapp583-fpga-configuration.pdf
> +
Missing allOf to spi-peripheral-props.
> +properties:
> + compatible:
> + items:
No need for items, drop it.
> + - enum:
> + - xlnx,fpga-slave-serial
> +
> + spi-cpha: true
> +
> + spi-max-frequency:
> + maximum: 60000000
> +
> + reg:
> + maxItems: 1
> +
> + prog_b-gpios:
> + description:
> + config pin (referred to as PROGRAM_B in the manual)
maxItems
> +
> + done-gpios:
> + description:
> + config status pin (referred to as DONE in the manual)
maxItems
> +
> + init-b-gpios:
> + description:
> + initialization status and configuration error pin
> + (referred to as INIT_B in the manual)
maxItems
> +
> +required:
> + - compatible
> + - reg
> + - prog_b-gpios
> + - done-gpios
> + - init-b-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + spi0 {
spi
> + #address-cells = <1>;
> + #size-cells = <0>;
> + fpga_mgr_spi: fpga-mgr@0 {
> + compatible = "xlnx,fpga-slave-serial";
> + spi-max-frequency = <60000000>;
> + spi-cpha;
> + reg = <0>;
> + prog_b-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
> + init-b-gpios = <&gpio0 28 GPIO_ACTIVE_LOW>;
> + done-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +...
Best regards,
Krzysztof
prev parent reply other threads:[~2023-02-24 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 11:37 [PATCH] dt-bindings: fpga: xilinx-spi: convert bindings to json-schema Nava kishore Manne
2023-02-24 14:55 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df19bef-5565-6961-3235-bf1ea21eabfe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.kishore.manne@amd.com \
--cc=robh+dt@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).