From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Will Deacon <will@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<gregkh@linuxfoundation.org>
Cc: <linuxarm@huawei.com>, Dan Williams <dan.j.williams@intel.com>,
Shaokun Zhang <zhangshaokun@hisilicon.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jiucheng Xu <jiucheng.xu@amlogic.com>,
Khuong Dinh <khuong@os.amperecomputing.com>,
Robert Richter <rric@kernel.org>,
Atish Patra <atishp@atishpatra.org>,
Anup Patel <anup@brainfault.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Frank Li <Frank.li@nxp.com>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Vineet Gupta <vgupta@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Fenghua Yu <fenghua.yu@intel.com>,
Dave Jiang <dave.jiang@intel.com>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>, <linux-fpga@vger.kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Liang Kan <kan.liang@linux.intel.com>
Subject: [PATCH 00/32] Add parents to struct pmu -> dev
Date: Tue, 4 Apr 2023 14:41:53 +0100 [thread overview]
Message-ID: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> (raw)
These are the low hanging fruit following GregKH's feedback that
all the devices registered via perf_pmu_register() should have parents.
Note that this causes potential ABI breakage.
It may fall in the category of it isn't breakage if no one notices
but I can't be certain of that. Whilst it is arguable that
no one should be been accessing PMUs except via the event_source
bus, there was documentation suggesting /sys/devices/ for particular
PMUs (because it was a shorter path?)
The first patch is pulled out of the series:
https://lore.kernel.org/linux-cxl/20230327170247.6968-1-Jonathan.Cameron@huawei.com/
[PATCH v3 0/5] CXL 3.0 Performance Monitoring Unit support
In that particular case it is very useful to be able to figure out which
CXL device the PMU device is associated with and looking at it's parents
in the device model as shown with ls -lh /sys/bus/event_sources/devices/
is a very easy way to do this (once it is correctly parented).
Addressing all the other instances of struct pmu not covered by this series
is likely to be a more complex discussion but unlikely to have an affect
on what is proposed here.
Documentation updates deliberately 'fixed' in separate patches before
changing the path to highlight that using /sys/bus/event_source/devices
path is unchanged by this series and that is presumed to be the
most common way these files are accessed.
Jonathan Cameron (32):
perf: Allow a PMU to have a parent
perf/hisi-pcie: Assign parent for event_source device
Documentation: hisi-pmu: Drop reference to /sys/devices path
perf/hisi-uncore: Assign parents for event_source devices
Documentation: hns-pmu: Use /sys/bus/event_source/devices paths
perf/hisi-hns3: Assign parents for event_source device
perf/amlogic: Assign parents for event_source devices
perf/arm_cspmu: Assign parents for event_source devices
Documentation: xgene-pmu: Use /sys/bus/event_source/devices paths
perf/xgene: Assign parents for event_source devices
Documentation: thunderx2-pmu: Use /sys/bus/event_source/devices paths
perf/thunderx2: Assign parents for event_source devices
perf/riscv: Assign parents for event_source devices
Documentation: qcom-pmu: Use /sys/bus/event_source/devices paths
perf/qcom: Assign parents for event_source devices
perf/imx_ddr: Assign parents for event_source devices
perf/arm_pmu: Assign parents for event_source devices
perf/alibaba_uncore: Assign parents for event_source device
perf/arm-cci: Assign parents for event_source device
perf/arm-ccn: Assign parents for event_source device
perf/arm-cmn: Assign parents for event_source device
perf/arm-dmc620: Assign parents for event_source device
perf/arm-dsu: Assign parents for event_source device
perf/arm-smmuv3: Assign parents for event_source device
perf/arm-spe: Assign parents for event_source device
arc: Assign parents for event_source devices
ARM: imx: Assign parents for mmdc event_source devices
dmaengine: idxd: Assign parent for event_source device
fpga: dfl: Assign parent for event_source device
drivers/nvdimm: Assign parent for event_source device
Documentation: ABI + trace: hisi_ptt: update paths to bus/event_source
hwtracing: hisi_ptt: Assign parent for event_source device
...i_ptt => sysfs-bus-event_source-devices-hisi_ptt} | 12 ++++++------
Documentation/admin-guide/perf/hisi-pmu.rst | 1 -
Documentation/admin-guide/perf/hns3-pmu.rst | 8 ++++----
Documentation/admin-guide/perf/qcom_l2_pmu.rst | 2 +-
Documentation/admin-guide/perf/qcom_l3_pmu.rst | 2 +-
Documentation/admin-guide/perf/thunderx2-pmu.rst | 2 +-
Documentation/admin-guide/perf/xgene-pmu.rst | 2 +-
Documentation/trace/hisi-ptt.rst | 4 ++--
MAINTAINERS | 2 +-
arch/arc/kernel/perf_event.c | 1 +
arch/arm/mach-imx/mmdc.c | 1 +
drivers/dma/idxd/perfmon.c | 1 +
drivers/fpga/dfl-fme-perf.c | 1 +
drivers/hwtracing/ptt/hisi_ptt.c | 1 +
drivers/nvdimm/nd_perf.c | 1 +
drivers/perf/alibaba_uncore_drw_pmu.c | 1 +
drivers/perf/amlogic/meson_ddr_pmu_core.c | 1 +
drivers/perf/arm-cci.c | 1 +
drivers/perf/arm-ccn.c | 1 +
drivers/perf/arm-cmn.c | 1 +
drivers/perf/arm_cspmu/arm_cspmu.c | 1 +
drivers/perf/arm_dmc620_pmu.c | 1 +
drivers/perf/arm_dsu_pmu.c | 1 +
drivers/perf/arm_pmu_platform.c | 1 +
drivers/perf/arm_smmuv3_pmu.c | 1 +
drivers/perf/arm_spe_pmu.c | 1 +
drivers/perf/fsl_imx8_ddr_perf.c | 1 +
drivers/perf/hisilicon/hisi_pcie_pmu.c | 1 +
drivers/perf/hisilicon/hisi_uncore_pmu.c | 1 +
drivers/perf/hisilicon/hns3_pmu.c | 1 +
drivers/perf/qcom_l2_pmu.c | 1 +
drivers/perf/qcom_l3_pmu.c | 1 +
drivers/perf/riscv_pmu_legacy.c | 1 +
drivers/perf/riscv_pmu_sbi.c | 1 +
drivers/perf/thunderx2_pmu.c | 1 +
drivers/perf/xgene_pmu.c | 1 +
include/linux/perf_event.h | 1 +
kernel/events/core.c | 1 +
38 files changed, 46 insertions(+), 18 deletions(-)
rename Documentation/ABI/testing/{sysfs-devices-hisi_ptt => sysfs-bus-event_source-devices-hisi_ptt} (83%)
--
2.37.2
next reply other threads:[~2023-04-04 13:44 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 13:41 Jonathan Cameron [this message]
2023-04-04 13:41 ` [PATCH 01/32] perf: Allow a PMU to have a parent Jonathan Cameron
2023-04-04 13:51 ` Greg KH
2023-04-06 4:03 ` Yicong Yang
2023-04-06 10:16 ` Jonathan Cameron
2023-04-06 12:40 ` Peter Zijlstra
2023-04-06 16:44 ` Jonathan Cameron
2023-04-06 17:08 ` Greg KH
2023-04-12 9:56 ` Jonathan Cameron
2023-04-06 19:49 ` Peter Zijlstra
2023-06-06 13:06 ` Mark Rutland
2023-06-06 13:18 ` Peter Zijlstra
2023-06-06 13:30 ` Mark Rutland
2023-06-06 13:48 ` Peter Zijlstra
2023-06-07 11:00 ` Robin Murphy
2023-04-12 12:41 ` Robin Murphy
2023-04-04 13:41 ` [PATCH 02/32] perf/hisi-pcie: Assign parent for event_source device Jonathan Cameron
2023-04-04 13:51 ` Greg KH
2023-04-06 3:56 ` Yicong Yang
2023-04-04 13:41 ` [PATCH 03/32] Documentation: hisi-pmu: Drop reference to /sys/devices path Jonathan Cameron
2023-04-04 13:52 ` Greg KH
2023-04-06 3:56 ` Yicong Yang
2023-04-04 13:41 ` [PATCH 04/32] perf/hisi-uncore: Assign parents for event_source devices Jonathan Cameron
2023-04-04 13:52 ` Greg KH
2023-04-06 3:57 ` Yicong Yang
2023-04-04 13:41 ` [PATCH 05/32] Documentation: hns-pmu: Use /sys/bus/event_source/devices paths Jonathan Cameron
2023-04-04 13:52 ` Greg KH
2023-04-04 13:41 ` [PATCH 06/32] perf/hisi-hns3: Assign parents for event_source device Jonathan Cameron
2023-04-04 13:42 ` [PATCH 07/32] perf/amlogic: Assign parents for event_source devices Jonathan Cameron
2023-04-10 2:00 ` Jiucheng Xu
2023-04-04 13:42 ` [PATCH 08/32] perf/arm_cspmu: " Jonathan Cameron
2023-04-04 14:50 ` Suzuki K Poulose
2023-04-04 13:42 ` [PATCH 09/32] Documentation: xgene-pmu: Use /sys/bus/event_source/devices paths Jonathan Cameron
2023-04-04 13:42 ` [PATCH 10/32] perf/xgene: Assign parents for event_source devices Jonathan Cameron
2023-04-04 13:42 ` [PATCH 11/32] Documentation: thunderx2-pmu: Use /sys/bus/event_source/devices paths Jonathan Cameron
2023-04-04 13:42 ` [PATCH 12/32] perf/thunderx2: Assign parents for event_source devices Jonathan Cameron
2023-04-04 13:42 ` [PATCH 13/32] perf/riscv: " Jonathan Cameron
2023-04-04 13:42 ` [PATCH 14/32] Documentation: qcom-pmu: Use /sys/bus/event_source/devices paths Jonathan Cameron
2023-04-04 13:42 ` [PATCH 15/32] perf/qcom: Assign parents for event_source devices Jonathan Cameron
2023-04-04 13:42 ` [PATCH 16/32] perf/imx_ddr: " Jonathan Cameron
2023-04-04 13:42 ` [PATCH 17/32] perf/arm_pmu: " Jonathan Cameron
2023-04-04 13:42 ` [PATCH 18/32] perf/alibaba_uncore: Assign parents for event_source device Jonathan Cameron
2023-04-05 3:50 ` Shuai Xue
2023-04-04 13:42 ` [PATCH 19/32] perf/arm-cci: " Jonathan Cameron
2023-04-04 14:45 ` Suzuki K Poulose
2023-04-04 13:42 ` [PATCH 20/32] perf/arm-ccn: " Jonathan Cameron
2023-04-12 12:09 ` Suzuki K Poulose
2023-04-04 13:42 ` [PATCH 21/32] perf/arm-cmn: " Jonathan Cameron
2023-04-12 11:52 ` Robin Murphy
2023-04-04 13:42 ` [PATCH 22/32] perf/arm-dmc620: " Jonathan Cameron
2023-04-04 13:42 ` [PATCH 23/32] perf/arm-dsu: " Jonathan Cameron
2023-04-04 14:52 ` Suzuki K Poulose
2023-04-04 13:42 ` [PATCH 24/32] perf/arm-smmuv3: " Jonathan Cameron
2023-04-04 13:42 ` [PATCH 25/32] perf/arm-spe: " Jonathan Cameron
2023-04-12 12:08 ` Suzuki K Poulose
2023-04-04 13:42 ` [PATCH 26/32] arc: Assign parents for event_source devices Jonathan Cameron
2023-04-04 13:42 ` [PATCH 27/32] ARM: imx: Assign parents for mmdc " Jonathan Cameron
2023-04-04 13:42 ` [PATCH 28/32] dmaengine: idxd: Assign parent for event_source device Jonathan Cameron
2023-04-04 13:42 ` [PATCH 29/32] fpga: dfl: " Jonathan Cameron
2023-04-07 6:42 ` Xu Yilun
2023-04-04 13:42 ` [PATCH 30/32] drivers/nvdimm: " Jonathan Cameron
2023-04-05 5:05 ` Dan Williams
2023-04-04 13:42 ` [PATCH 31/32] Documentation: ABI + trace: hisi_ptt: update paths to bus/event_source Jonathan Cameron
2023-04-06 3:54 ` Yicong Yang
2023-04-04 13:42 ` [PATCH 32/32] hwtracing: hisi_ptt: Assign parent for event_source device Jonathan Cameron
2023-04-06 3:55 ` Yicong Yang
2023-04-04 13:51 ` [PATCH 00/32] Add parents to struct pmu -> dev Greg KH
2023-04-04 14:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404134225.13408-1-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Frank.li@nxp.com \
--cc=acme@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=jiucheng.xu@amlogic.com \
--cc=kan.liang@linux.intel.com \
--cc=khuong@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rric@kernel.org \
--cc=shawnguo@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=trix@redhat.com \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).