From: Rob Herring <robh@kernel.org>
To: Michal Simek <michal.simek@amd.com>
Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
git@xilinx.com, Moritz Fischer <mdf@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
monstr@monstr.eu, Xu Yilun <yilun.xu@intel.com>,
"open list:FPGA MANAGER FRAMEWORK" <linux-fpga@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v4] dt-bindings: fpga: Convert fpga-region binding to yaml
Date: Wed, 31 Jan 2024 14:09:15 -0600 [thread overview]
Message-ID: <170673175226.2219463.1221634595095812617.robh@kernel.org> (raw)
In-Reply-To: <37b107d86b39ef4bc9c482b57b27de8b92c3fa43.1706530726.git.michal.simek@amd.com>
On Mon, 29 Jan 2024 13:18:53 +0100, Michal Simek wrote:
> Convert the generic fpga region DT binding to json-schema.
> There are some differences compare to txt version.
> 1. DT overlay can't be described in example that's why directly include
> information from overlay to node which was referenced. It is visible in
> example with /* DT Overlay contains: &... */
>
> 2. All example have been rewritten to be simpler and describe only full
> reconfiguration and partial reconfiguration with one bridge.
> Completely drop the case where fpga region can inside partial
> reconfiguration region which is already described in description
>
> 3. Fixed some typos in descriptions compare to txt version but most of it
> is just c&p from txt file.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> Changes in v4:
> - permit only object type as additionalProperties
> - describe also optional reg/ranges properties and remove required
> #address/size-cells properties
>
> Changes in v3:
> - drop fpga bridge and mgr descriptions in example
> - use additionalProperties: true
> - use fixed-factor-clock instead
> - fixed matching pattern
>
> Changes in v2:
> - Fix typo in subject
> - Fix comment in bridge example
> - Change license back to gpl-2.0 only
> - Do not define firware-name type and add maxItems 1
> - Make fpga-bridge phandle-array
> - Drop ranges property because of missing reg property of fpga-region
> - Also describe case with fixed clock node and axi bus
> - Fix fpga-region names in example
>
> Please let me know if there is a way to describe overlays to dt root to be
> able to reference fpga region back.
>
> fpga-region without MMIO access is also permitted that's why there is no
> need to describe reg/ranges and #.*cells properties for these cases.
>
> ---
> .../devicetree/bindings/fpga/fpga-region.txt | 479 ------------------
> .../devicetree/bindings/fpga/fpga-region.yaml | 358 +++++++++++++
> 2 files changed, 358 insertions(+), 479 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/fpga/fpga-region.txt
> create mode 100644 Documentation/devicetree/bindings/fpga/fpga-region.yaml
>
Applied, thanks!
prev parent reply other threads:[~2024-01-31 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 12:18 [PATCH v4] dt-bindings: fpga: Convert fpga-region binding to yaml Michal Simek
2024-01-31 20:09 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170673175226.2219463.1221634595095812617.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=hao.wu@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh+dt@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).