From: Rogan Dawes <rogan@dawes.za.net>
To: Josh Boyer <jwboyer@kernel.org>
Cc: linux-firmware@kernel.org
Subject: Re: [PATCH] brcm: Add 4334 NVRAM for the Wink Hub v1
Date: Thu, 7 Sep 2023 16:58:45 +0200 [thread overview]
Message-ID: <CAOYdKdiGRK3dCz2fx+=vmZ5ZcwstmH=Q=OQyC3aJctNYnMbqKg@mail.gmail.com> (raw)
In-Reply-To: <CA+5PVA79oa-9vrgMmgf9VoR0mswVr+H4DuMtrPCYVg0odZf2Pg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3646 bytes --]
Hi Josh,
Thanks for taking a look. This configuration file was taken verbatim from
the vendor firmware, shipped with the device, but had no license directly
attributable to this file. Is it something that can still be accepted?
Not sure how to add that sort of origin to the WHENCE file (although it was
described in the commit message).
If you could give me a pointer to something similar, I would be happy to
resubmit.
Regards,
Rogan
On Thu, 7 Sept 2023 at 13:44, Josh Boyer <jwboyer@kernel.org> wrote:
> On Wed, Sep 6, 2023 at 11:28 AM Rogan Dawes <rogan@dawes.za.net> wrote:
> >
> > Add a NVRAM file for the Broadcom 4334 Wifi/BT module as used on the
> > Wink Hub v1 home automation gateway. This file has been lifted directly
> > from the vendor firmware image, and has been tested using a custom
> > OpenWrt build.
> >
> > Signed-off-by: Rogan Dawes <rogan@dawes.za.net>
> > ---
> > ...cmfmac4334-sdio.wink,imx28-wink-hub-v1.txt | 101 ++++++++++++++++++
> > 1 file changed, 101 insertions(+)
> > create mode 100644 brcm/brcmfmac4334-sdio.wink,imx28-wink-hub-v1.txt
> >
> > diff --git a/brcm/brcmfmac4334-sdio.wink,imx28-wink-hub-v1.txt
> b/brcm/brcmfmac4334-sdio.wink,imx28-wink-hub-v1.txt
> > new file mode 100644
> > index 00000000..e63019b0
> > --- /dev/null
> > +++ b/brcm/brcmfmac4334-sdio.wink,imx28-wink-hub-v1.txt
>
> This fails to apply for some reason, and you didn't add an entry into
> WHENCE. Can you fix it up and resend?
>
> josh
>
> > @@ -0,0 +1,101 @@
> > +# SWB-B53_B1_R04_eLNA 10/21/2011
> > +
> > +manfid=0x2d0
> > +prodid=0x05c1
> > +vendid=0x14e4
> > +devid=0x4380
> > +boardtype=0x05de
> > +boardrev=0x1105
> > +boardnum=22
> > +macaddr=00:90:4c:c5:12:38
> > +sromrev=0
> > +
> > +boardflags=0x10081a00
> > +xtalfreq=37400
> > +nocrc=1
> > +ag0=255
> > +aa2g=1
> > +ccode=ALL
> > +pa0itssit=0x20
> > +
> > +#PA parameters for 2.4GHz (0x15A7,0xFD54,0xFF4A)
> > +pa0b0=0x19B7
> > +pa0b1=0xFD2A
> > +pa0b2=0xFF7B
> > +extpagain2g=2
> > +extpagain5g=2
> > +
> > +# rssi params for 2.4GHz
> > +rssismf2g=0x2
> > +rssismc2g=0x7
> > +rssisav2g=0x1
> > +cckPwrOffset=0
> > +
> > +# rssi params for 5GHz
> > +rssismf5g=0x8
> > +rssismc5g=0x8
> > +rssisav5g=0x1
> > +
> > +
> > +#PA parameters for lower a-band
> > +pa1lob0=5516
> > +pa1lob1=-680
> > +pa1lob2=-182
> > +#PA parameters for midband
> > +pa1b0=5560
> > +pa1b1=-683
> > +pa1b2=-178
> > +#PA paramasdeters for high band
> > +pa1hib0=5438
> > +pa1hib1=-681
> > +pa1hib2=-193
> > +rxpo5g=0
> > +
> > +
> > +maxp2ga0=66
> > +ofdm2gpo=0x22222222
> > +mcs2gpo0=0x4444
> > +mcs2gpo1=0x4444
> > +
> > +maxp5ga0=0x4a
> > +maxp5gla0=0x4a
> > +maxp5gha0=0x4a
> > +ofdm5gpo=0x66666666
> > +ofdm5glpo=0x66666666
> > +ofdm5ghpo=0x66666666
> > +mcs5gpo0=0x8888
> > +mcs5gpo1=0x8888
> > +mcs5glpo0=0x8888
> > +mcs5glpo1=0x8888
> > +mcs5ghpo0=0x8888
> > +mcs5ghpo1=0x8888
> > +
> > +#il0macaddr=00:90:4c:c5:12:38
> > +wl0id=0x431b
> > +pagc2g=0x10
> > +#dacgc2g=4
> > +txalpfbyp=1
> > +
> > +#For SEMCO B53-R04-eLNA Module
> > +swctrlmap_2g=0x0c0c0c0c,0x12121212,0x02020202,0x11202,0x1ff
> > +swctrlmap_5g=0x40404040,0x20202020,0x20202020,0x12202,0x2f8
> > +
> > +gain=32
> > +triso2g=12
> > +triso5g=8
> > +
> > +hostwake=0x40
> > +hostrdy=0x41
> > +usbrdy=0x03
> > +usbrdydelay=100
> > +deadman_to=0xffffffff
> > +muxenab=0x1
> > +
> > +tssioffsetmax=27
> > +
> > +PwrOffset40mhz2g=0
> > +PwrOffset40mhz5g=-8
> > +
> > +tssioffsetmax5gl=21
> > +tssioffsetmax5gm=23
> > +tssioffsetmax5gh=20
> > --
> > 2.34.1
> >
>
[-- Attachment #2: Type: text/html, Size: 4792 bytes --]
prev parent reply other threads:[~2023-09-07 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 15:28 [PATCH] brcm: Add 4334 NVRAM for the Wink Hub v1 Rogan Dawes
2023-09-07 11:44 ` Josh Boyer
2023-09-07 14:58 ` Rogan Dawes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOYdKdiGRK3dCz2fx+=vmZ5ZcwstmH=Q=OQyC3aJctNYnMbqKg@mail.gmail.com' \
--to=rogan@dawes.za.net \
--cc=jwboyer@kernel.org \
--cc=linux-firmware@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).