From: Josh Boyer <jwboyer@kernel.org>
To: Juerg Haefliger <juerg.haefliger@canonical.com>
Cc: linux-firmware@kernel.org, jwboyer@kernel.org
Subject: Re: [PATCH] check_whence: Add a check for duplicate link entries
Date: Mon, 19 Feb 2024 07:51:00 -0500 [thread overview]
Message-ID: <CA+5PVA6rZ4UjdyWz3q0LfE+VqmqJoRSquqykD2UhgW+Gd8znPQ@mail.gmail.com> (raw)
In-Reply-To: <20240202144102.1209374-1-juerg.haefliger@canonical.com>
On Fri, Feb 2, 2024 at 9:41 AM Juerg Haefliger
<juerg.haefliger@canonical.com> wrote:
>
> Verify that there a no duplicate 'Link:' entries in the WHENCE file.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Applied and pushed out.
https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/146
josh
> ---
> check_whence.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/check_whence.py b/check_whence.py
> index 4b5471e04a6f..fd74a56a5c5a 100755
> --- a/check_whence.py
> +++ b/check_whence.py
> @@ -70,6 +70,7 @@ def main():
> whence_list = list(list_whence())
> whence_files = list(list_whence_files())
> links_list = list(list_links_list())
> + whence_links = list(zip(*links_list))[0]
> known_files = set(name for name in whence_list if not name.endswith("/")) | set(
> [
> ".gitignore",
> @@ -102,6 +103,10 @@ def main():
> sys.stderr.write("E: %s listed in WHENCE twice\n" % name)
> ret = 1
>
> + for name in set(link for link in whence_links if whence_links.count(link) > 1):
> + sys.stderr.write("E: %s listed in WHENCE twice\n" % name)
> + ret = 1
> +
> for name in set(link for link in whence_files if os.path.islink(link)):
> sys.stderr.write("E: %s listed in WHENCE as File, but is a symlink\n" % name)
> ret = 1
> --
> 2.40.1
>
prev parent reply other threads:[~2024-02-19 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 14:41 [PATCH] check_whence: Add a check for duplicate link entries Juerg Haefliger
2024-02-19 12:51 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+5PVA6rZ4UjdyWz3q0LfE+VqmqJoRSquqykD2UhgW+Gd8znPQ@mail.gmail.com \
--to=jwboyer@kernel.org \
--cc=juerg.haefliger@canonical.com \
--cc=linux-firmware@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).