From: Helge Deller <deller@gmx.de>
To: Fullway Wang <fullwaywang@outlook.com>,
tzimmermann@suse.de, sam@ravnborg.org, javierm@redhat.com
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
fullwaywang@tencent.com
Subject: Re: [PATCH] video: fbdev: sis: Error out if pixclock equals zero
Date: Sun, 21 Jan 2024 09:01:55 +0100 [thread overview]
Message-ID: <fb18e94f-3254-48d1-b260-1c3a7514bd8f@gmx.de> (raw)
In-Reply-To: <PH7PR20MB5925C492B7F8CDACB2386DB4BF712@PH7PR20MB5925.namprd20.prod.outlook.com>
On 1/18/24 07:24, Fullway Wang wrote:
> The userspace program could pass any values to the driver through
> ioctl() interface. If the driver doesn't check the value of pixclock,
> it may cause divide-by-zero error.
>
> In sisfb_check_var(), var->pixclock is used as a divisor to caculate
> drate before it is checked against zero. Fix this by checking it
> at the beginning.
>
> This is similar to CVE-2022-3061 in i740fb which was fixed by
> commit 15cf0b8.
>
> Signed-off-by: Fullway Wang <fullwaywang@outlook.com>
> ---
> drivers/video/fbdev/sis/sis_main.c | 2 ++
> 1 file changed, 2 insertions(+)
I've applied this patch and your savage patch to fbdev git tree.
Thanks!
Helge
prev parent reply other threads:[~2024-01-21 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 6:24 [PATCH] video: fbdev: sis: Error out if pixclock equals zero Fullway Wang
2024-01-21 8:01 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb18e94f-3254-48d1-b260-1c3a7514bd8f@gmx.de \
--to=deller@gmx.de \
--cc=fullwaywang@outlook.com \
--cc=fullwaywang@tencent.com \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).