From: Helge Deller <deller@gmx.de>
To: Thomas Zimmermann <tzimmermann@suse.de>,
mbroemme@libmpq.org, javierm@redhat.com
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] fbdev/intelfb: Remove driver
Date: Mon, 8 Jan 2024 10:30:14 +0100 [thread overview]
Message-ID: <eb69de14-411c-4a45-bcfb-ad7399d874bc@gmx.de> (raw)
In-Reply-To: <20240105091127.23087-1-tzimmermann@suse.de>
On 1/5/24 10:10, Thomas Zimmermann wrote:
> From looking at the PCI IDs, every device supported by intelfb is
> also supported by i915. Anyone still using intelfb should please
> move on to i915, which does everything intelfb does but better.
>
> Removing intelfb is motivated by the driver's excessive use of the
> global screen_info state. The state belongs to architecture and
> firmware code; device drivers should not attempt to access it. But
> fixing intelfb would require a significant change in the driver's
> probing logic. As intelfb has been obsolete for nearly 2 decades,
> it is probably not worth the effort. Let's just remove it. Also
> remove the related documentation.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> Documentation/fb/index.rst | 1 -
> Documentation/fb/intelfb.rst | 155 --
> .../userspace-api/ioctl/ioctl-number.rst | 1 -
> MAINTAINERS | 7 -
> drivers/Makefile | 3 +-
> drivers/video/fbdev/Kconfig | 39 -
> drivers/video/fbdev/intelfb/Makefile | 8 -
> drivers/video/fbdev/intelfb/intelfb.h | 382 ---
> drivers/video/fbdev/intelfb/intelfb_i2c.c | 209 --
> drivers/video/fbdev/intelfb/intelfbdrv.c | 1680 -------------
> drivers/video/fbdev/intelfb/intelfbhw.c | 2115 -----------------
> drivers/video/fbdev/intelfb/intelfbhw.h | 609 -----
> 12 files changed, 1 insertion(+), 5208 deletions(-)
> delete mode 100644 Documentation/fb/intelfb.rst
> delete mode 100644 drivers/video/fbdev/intelfb/Makefile
> delete mode 100644 drivers/video/fbdev/intelfb/intelfb.h
> delete mode 100644 drivers/video/fbdev/intelfb/intelfb_i2c.c
> delete mode 100644 drivers/video/fbdev/intelfb/intelfbdrv.c
> delete mode 100644 drivers/video/fbdev/intelfb/intelfbhw.c
> delete mode 100644 drivers/video/fbdev/intelfb/intelfbhw.h
applied to fbdev git tree.
Thanks!
Helge
prev parent reply other threads:[~2024-01-08 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 9:10 [PATCH] fbdev/intelfb: Remove driver Thomas Zimmermann
2024-01-05 10:20 ` Maik Broemme
2024-01-08 8:53 ` Thomas Zimmermann
2024-01-08 9:30 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb69de14-411c-4a45-bcfb-ad7399d874bc@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=mbroemme@libmpq.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).