From: Helge Deller <deller@gmx.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Daniel Vetter <daniel@ffwll.ch>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] fbcon: Fix incorrect printed function name in fbcon_prepare_logo()
Date: Mon, 22 Jan 2024 22:42:05 +0100 [thread overview]
Message-ID: <de2bae83-f6dd-4097-b94a-6086c527360c@gmx.de> (raw)
In-Reply-To: <d15dd1d81ffebed4e5028e156f0082c44ebbf2fc.1705935864.git.geert+renesas@glider.be>
On 1/22/24 16:04, Geert Uytterhoeven wrote:
> If the boot logo does not fit, a message is printed, including a wrong
> function name prefix. Instead of correcting the function name (or using
> __func__), just use "fbcon", like is done in several other messages.
>
> While at it, modernize the call by switching to pr_info().
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
applied to fbdev git tree.
Thanks!
Helge
> ---
> drivers/video/fbdev/core/fbcon.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 63af6ab034b5f1bb..1183e7a871f8b270 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -631,8 +631,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info,
>
> if (logo_lines > vc->vc_bottom) {
> logo_shown = FBCON_LOGO_CANSHOW;
> - printk(KERN_INFO
> - "fbcon_init: disable boot-logo (boot-logo bigger than screen).\n");
> + pr_info("fbcon: disable boot-logo (boot-logo bigger than screen).\n");
> } else {
> logo_shown = FBCON_LOGO_DRAW;
> vc->vc_top = logo_lines;
prev parent reply other threads:[~2024-01-22 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 15:04 [PATCH] fbcon: Fix incorrect printed function name in fbcon_prepare_logo() Geert Uytterhoeven
2024-01-22 21:42 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de2bae83-f6dd-4097-b94a-6086c527360c@gmx.de \
--to=deller@gmx.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).