From: Helge Deller <deller@gmx.de>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Arnd Bergmann <arnd@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] fbdev: add HAS_IOPORT dependencies
Date: Wed, 10 Apr 2024 15:24:57 +0200 [thread overview]
Message-ID: <d701de84-8ee3-40a5-9dc8-575f516560e8@gmx.de> (raw)
In-Reply-To: <20240410105626.2743168-2-schnelle@linux.ibm.com>
On 4/10/24 12:56, Niklas Schnelle wrote:
> In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> compile time. We thus need to add HAS_IOPORT as dependency for those
> drivers using them.
>
> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
added to fbdev git tree.
Thanks!
Helge
> ---
> Note: This patch does not depend any not-yet-mainline HAS_IOPORT changes
> and may be merged via subsystem specific trees at your earliest
> convenience.
>
> v1 -> v2:
> - Add dependency for FB_ARC
>
> drivers/video/fbdev/Kconfig | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 197b6d5268e9..76bbfd3767da 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -157,7 +157,7 @@ config FB_IMX
>
> config FB_CYBER2000
> tristate "CyberPro 2000/2010/5000 support"
> - depends on FB && PCI && (BROKEN || !SPARC64)
> + depends on FB && PCI && HAS_IOPORT && (BROKEN || !SPARC64)
> select FB_IOMEM_HELPERS
> help
> This enables support for the Integraphics CyberPro 20x0 and 5000
> @@ -245,7 +245,7 @@ config FB_FM2
>
> config FB_ARC
> tristate "Arc Monochrome LCD board support"
> - depends on FB && (X86 || COMPILE_TEST)
> + depends on FB && HAS_IOPORT && (X86 || COMPILE_TEST)
> select FB_SYSMEM_HELPERS_DEFERRED
> help
> This enables support for the Arc Monochrome LCD board. The board
> @@ -1046,7 +1046,7 @@ config FB_ATY_BACKLIGHT
>
> config FB_S3
> tristate "S3 Trio/Virge support"
> - depends on FB && PCI
> + depends on FB && PCI && HAS_IOPORT
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -1107,7 +1107,7 @@ config FB_SAVAGE_ACCEL
>
> config FB_SIS
> tristate "SiS/XGI display support"
> - depends on FB && PCI
> + depends on FB && PCI && HAS_IOPORT
> select BOOT_VESA_SUPPORT if FB_SIS = y
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> @@ -1138,7 +1138,7 @@ config FB_SIS_315
>
> config FB_VIA
> tristate "VIA UniChrome (Pro) and Chrome9 display support"
> - depends on FB && PCI && GPIOLIB && I2C && (X86 || COMPILE_TEST)
> + depends on FB && PCI && GPIOLIB && I2C && HAS_IOPORT && (X86 || COMPILE_TEST)
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -1177,7 +1177,7 @@ endif
>
> config FB_NEOMAGIC
> tristate "NeoMagic display support"
> - depends on FB && PCI
> + depends on FB && PCI && HAS_IOPORT
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -1204,7 +1204,7 @@ config FB_KYRO
>
> config FB_3DFX
> tristate "3Dfx Banshee/Voodoo3/Voodoo5 display support"
> - depends on FB && PCI
> + depends on FB && PCI && HAS_IOPORT
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -1252,7 +1252,7 @@ config FB_VOODOO1
>
> config FB_VT8623
> tristate "VIA VT8623 support"
> - depends on FB && PCI
> + depends on FB && PCI && HAS_IOPORT
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -1267,7 +1267,7 @@ config FB_VT8623
>
> config FB_TRIDENT
> tristate "Trident/CyberXXX/CyberBlade support"
> - depends on FB && PCI
> + depends on FB && PCI && HAS_IOPORT
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -1290,7 +1290,7 @@ config FB_TRIDENT
>
> config FB_ARK
> tristate "ARK 2000PV support"
> - depends on FB && PCI
> + depends on FB && PCI && HAS_IOPORT
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> @@ -1814,7 +1814,7 @@ config FB_SSD1307
>
> config FB_SM712
> tristate "Silicon Motion SM712 framebuffer support"
> - depends on FB && PCI
> + depends on FB && PCI && HAS_IOPORT
> select FB_IOMEM_HELPERS
> help
> Frame buffer driver for the Silicon Motion SM710, SM712, SM721
prev parent reply other threads:[~2024-04-10 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 10:56 [PATCH v2 0/1] fbdev: Handle HAS_IOPORT dependencies Niklas Schnelle
2024-04-10 10:56 ` [PATCH v2 1/1] fbdev: add " Niklas Schnelle
2024-04-10 13:24 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d701de84-8ee3-40a5-9dc8-575f516560e8@gmx.de \
--to=deller@gmx.de \
--cc=arnd@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hca@linux.ibm.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).