From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Flavio Suligoi <f.suligoi@asem.it>,
Hans de Goede <hdegoede@redhat.com>,
Jianhua Lu <lujianhua000@gmail.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Helge Deller <deller@gmx.de>, Jingoo Han <jingoohan1@gmail.com>,
Karel Balej <balejk@matfyz.cz>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: expresswire: don't depend on NEW_LEDS
Date: Thu, 15 Feb 2024 13:17:48 +0100 [thread overview]
Message-ID: <12382376.O9o76ZdvQC@radijator> (raw)
In-Reply-To: <20240215114831.GE9758@aspen.lan>
On Thursday, February 15, 2024 12:48:31 PM CET Daniel Thompson wrote:
> On Mon, Feb 12, 2024 at 09:03:26PM +0100, Duje Mihanović wrote:
...
> > Link: https://lore.kernel.org/20240212111819.936815-1-arnd@kernel.org
> > Reported-by: Arnd Bergmann <arnd@arndb.de>
> > Suggested-by: Daniel Thompson <daniel.thompson@linaro.org>
> > Fixes: 25ae5f5f4168 ("leds: Introduce ExpressWire library")
> > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
I must note that checkpatch actually complains about this patch (I may have
hit send too early):
0002-leds-expresswire-don-t-depend-on-NEW_LEDS.patch
----------------------------------------------------
WARNING: Reported-by: should be immediately followed by Closes: with a URL to
the report
#21:
Reported-by: Arnd Bergmann <arnd@arndb.de>
Suggested-by: Daniel Thompson <daniel.thompson@linaro.org>
total: 0 errors, 1 warnings, 22 lines checked
Could that Link: above be transformed into a Closes:?
Regards,
--
Duje
prev parent reply other threads:[~2024-02-15 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 20:03 [PATCH 0/2] leds: expresswire: Fix dependencies Duje Mihanović
2024-02-12 20:03 ` [PATCH 1/2] Revert "leds: Only descend into leds directory when CONFIG_NEW_LEDS is set" Duje Mihanović
2024-02-15 11:49 ` Daniel Thompson
2024-02-12 20:03 ` [PATCH 2/2] leds: expresswire: don't depend on NEW_LEDS Duje Mihanović
2024-02-15 11:48 ` Daniel Thompson
2024-02-15 12:17 ` Duje Mihanović [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12382376.O9o76ZdvQC@radijator \
--to=duje.mihanovic@skole.hr \
--cc=arnd@arndb.de \
--cc=balejk@matfyz.cz \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.suligoi@asem.it \
--cc=hdegoede@redhat.com \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=pavel@ucw.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).