From: Wang Jianjian <wangjianjian0@foxmail.com>
To: linux-f2fs-devel@lists.sourceforge.net, jaegeuk@kernel.org,
chao@kernel.org
Cc: Wang Jianjian <wangjianjian0@foxmail.com>
Subject: [f2fs-dev] [PATCH] f2fs: Fix incorrect return value
Date: Thu, 4 Apr 2024 21:47:20 +0800 [thread overview]
Message-ID: <tencent_67A0192ABE8A513889F4DCEEFD83DC2FBB0A@qq.com> (raw)
dquot_mark_dquot_dirty returns old dirty state not the error code.
Signed-off-by: Wang Jianjian <wangjianjian0@foxmail.com>
---
fs/f2fs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index a6867f26f141..af07027475d9 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -3063,13 +3063,13 @@ static int f2fs_dquot_mark_dquot_dirty(struct dquot *dquot)
{
struct super_block *sb = dquot->dq_sb;
struct f2fs_sb_info *sbi = F2FS_SB(sb);
- int ret = dquot_mark_dquot_dirty(dquot);
+ dquot_mark_dquot_dirty(dquot);
/* if we are using journalled quota */
if (is_journalled_quota(sbi))
set_sbi_flag(sbi, SBI_QUOTA_NEED_FLUSH);
- return ret;
+ return 0;
}
static int f2fs_dquot_commit_info(struct super_block *sb, int type)
--
2.34.3
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2024-04-04 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 13:47 Wang Jianjian [this message]
2024-04-07 6:23 ` [f2fs-dev] [PATCH] f2fs: Fix incorrect return value Chao Yu
2024-04-09 6:47 ` wangjianjian (C) via Linux-f2fs-devel
2024-04-11 9:28 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_67A0192ABE8A513889F4DCEEFD83DC2FBB0A@qq.com \
--to=wangjianjian0@foxmail.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).