From: Chao Yu <chao@kernel.org>
To: Zhiguo Niu <niuzhiguo84@gmail.com>
Cc: ke.wang@unisoc.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, hongyu.jin@unisoc.com,
Zhiguo Niu <zhiguo.niu@unisoc.com>,
jaegeuk@kernel.org
Subject: Re: [f2fs-dev] [PATCH V2] f2fs: fix to adjust appropirate defragment pg_end
Date: Wed, 27 Mar 2024 15:38:34 +0800 [thread overview]
Message-ID: <0ed07576-256c-4ed7-8ddc-33ed788a45ac@kernel.org> (raw)
In-Reply-To: <CAHJ8P3J3xK2uz7egvShyCeAjGFJ87AvqKxVN=NFiKDgMLMJDPg@mail.gmail.com>
On 2024/3/27 9:26, Zhiguo Niu wrote:
> On Tue, Mar 26, 2024 at 7:11 PM Chao Yu <chao@kernel.org> wrote:
>>
>> On 2024/3/25 13:56, Zhiguo Niu wrote:
>>> A length that exceeds the real size of the inode may be
>>> specified from user, although these out-of-range areas
>>> are not mapped, but they still need to be check in
>>> while loop, which is unnecessary.
>>>
>>> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
>>> ---
>>> v2: check i_size within inode lock according to Chao's suggestions
>>> ---
>>> ---
>>> fs/f2fs/file.c | 11 +++++++----
>>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>>> index 128e53d..cf63db7 100644
>>> --- a/fs/f2fs/file.c
>>> +++ b/fs/f2fs/file.c
>>> @@ -2608,9 +2608,6 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi,
>>> bool fragmented = false;
>>> int err;
>>>
>>> - pg_start = range->start >> PAGE_SHIFT;
>>> - pg_end = (range->start + range->len) >> PAGE_SHIFT;
>>> -
>>> f2fs_balance_fs(sbi, true);
>>>
>>> inode_lock(inode);
>>> @@ -2629,10 +2626,16 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi,
>>
>> pg_start = range->start >> PAGE_SHIFT;
>> pg_end = min_t(pgoff_t, (range->start + range->len) >> PAGE_SHIFT,
>> DIV_ROUND_UP(i_size_read(inode), PAGE_SIZE));
>>
>>>
>>> /* writeback all dirty pages in the range */
>>> err = filemap_write_and_wait_range(inode->i_mapping, range->start,
>>> - range->start + range->len - 1);
>>> + min_t(loff_t, range->start + range->len - 1,
>>> + i_size_read(inode) - 1));
>>
>> , pg_start << PAGE_SHIFT - 1, pg_end << PAGE_SHIFT - 1); ?
> should be pg_start << PAGE_SHIFT , pg_end << PAGE_SHIFT - 1)??
Oh, yes. :)
Thanks,
> if range.start=0, pg_start is also 0, lstart in
> filemap_write_and_wait_range is 0,
> but pg_start << PAGE_SHIFT - 1 will get lstart=-1?
> thanks！
>>
>> Thanks,
>>
>>> if (err)
>>> goto out;
>>>
>>> + pg_start = range->start >> PAGE_SHIFT;
>>> + pg_end = min_t(pgoff_t,
>>> + (range->start + range->len) >> PAGE_SHIFT,
>>> + DIV_ROUND_UP(i_size_read(inode), PAGE_SIZE));
>>> +
>>> /*
>>> * lookup mapping info in extent cache, skip defragmenting if physical
>>> * block addresses are continuous.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2024-03-27 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 5:56 [f2fs-dev] [PATCH V2] f2fs: fix to adjust appropirate defragment pg_end Zhiguo Niu
2024-03-26 11:11 ` Chao Yu
2024-03-27 1:26 ` Zhiguo Niu
2024-03-27 7:38 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ed07576-256c-4ed7-8ddc-33ed788a45ac@kernel.org \
--to=chao@kernel.org \
--cc=hongyu.jin@unisoc.com \
--cc=jaegeuk@kernel.org \
--cc=ke.wang@unisoc.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).