From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Eugen Hristev <eugen.hristev@collabora.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, jaegeuk@kernel.org,
chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, brauner@kernel.org,
jack@suse.cz, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, kernel@collabora.com
Subject: Re: [f2fs-dev] [PATCH v15 7/9] f2fs: Log error when lookup of encoded dentry fails
Date: Thu, 04 Apr 2024 19:05:10 -0400 [thread overview]
Message-ID: <87v84w3f15.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <e6d1ad0b-719a-4693-bd34-bea3cf6e4fa2@collabora.com> (Eugen Hristev's message of "Thu, 4 Apr 2024 17:50:29 +0300")
Eugen Hristev <eugen.hristev@collabora.com> writes:
> On 4/3/24 07:25, Eric Biggers wrote:
>> On Tue, Apr 02, 2024 at 06:48:40PM +0300, Eugen Hristev via Linux-f2fs-devel wrote:
>>> If the volume is in strict mode, generi c_ci_compare can report a broken
>>> encoding name. This will not trigger on a bad lookup, which is caught
>>> earlier, only if the actual disk name is bad.
>>>
>>> Suggested-by: Gabriel Krisman Bertazi <krisman@suse.de>
>>> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
>>> ---
>>> fs/f2fs/dir.c | 15 ++++++++++-----
>>> 1 file changed, 10 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
>>> index 88b0045d0c4f..64286d80dd30 100644
>>> --- a/fs/f2fs/dir.c
>>> +++ b/fs/f2fs/dir.c
>>> @@ -192,11 +192,16 @@ static inline int f2fs_match_name(const struct inode *dir,
>>> struct fscrypt_name f;
>>>
>>> #if IS_ENABLED(CONFIG_UNICODE)
>>> - if (fname->cf_name.name)
>>> - return generic_ci_match(dir, fname->usr_fname,
>>> - &fname->cf_name,
>>> - de_name, de_name_len);
>>> -
>>> + if (fname->cf_name.name) {
>>> + int ret = generic_ci_match(dir, fname->usr_fname,
>>> + &fname->cf_name,
>>> + de_name, de_name_len);
>>> + if (ret == -EINVAL)
>>> + f2fs_warn(F2FS_SB(dir->i_sb),
>>> + "Directory contains filename that is invalid UTF-8");
>>> +
>>
>> Shouldn't this use f2fs_warn_ratelimited?
>
> f2fs_warn_ratelimited appears to be very new in the kernel,
>
> Krisman do you think you can rebase your for-next on top of latest such that this
> function is available ? I am basing the series on your for-next
> branch.
I try to make unicode/for-next a non-rebase branch, and I don't want to
pollute the tree with an unecessary backmerge. Instead, why not base
your work on a more recent branch, since it has no dependencies on
anything from unicode/for-next?
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2024-04-04 23:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 15:48 [PATCH v15 0/9] Cache insensitive cleanup for ext4/f2fs Eugen Hristev
2024-04-02 15:48 ` [PATCH v15 1/9] ext4: Simplify the handling of cached insensitive names Eugen Hristev
2024-04-02 15:48 ` [PATCH v15 2/9] f2fs: " Eugen Hristev
2024-04-03 3:30 ` Eric Biggers
2024-04-02 15:48 ` [PATCH v15 3/9] libfs: Introduce case-insensitive string comparison helper Eugen Hristev
2024-04-03 3:36 ` Eric Biggers
2024-04-02 15:48 ` [PATCH v15 4/9] ext4: Reuse generic_ci_match for ci comparisons Eugen Hristev
2024-04-03 3:43 ` Eric Biggers
2024-04-03 4:20 ` Eric Biggers
2024-04-02 15:48 ` [PATCH v15 5/9] f2fs: " Eugen Hristev
2024-04-02 15:48 ` [PATCH v15 6/9] ext4: Log error when lookup of encoded dentry fails Eugen Hristev
2024-04-03 4:22 ` [f2fs-dev] " Eric Biggers
2024-04-03 14:39 ` Gabriel Krisman Bertazi
2024-04-02 15:48 ` [PATCH v15 7/9] f2fs: " Eugen Hristev
2024-04-03 4:25 ` [f2fs-dev] " Eric Biggers
2024-04-04 14:50 ` Eugen Hristev
2024-04-04 23:05 ` Gabriel Krisman Bertazi [this message]
2024-04-02 15:48 ` [PATCH v15 8/9] ext4: Move CONFIG_UNICODE defguards into the code flow Eugen Hristev
2024-04-02 15:48 ` [PATCH v15 9/9] f2fs: " Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v84w3f15.fsf@mailhost.krisman.be \
--to=krisman@suse.de \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).