From: Luis Henriques <lhenriques@suse.de>
To: linux-ext4@vger.kernel.org
Cc: Christian Brauner <brauner@kernel.org>
Subject: fstest generic/696 failure on ext4 fs with quotas+idmap
Date: Wed, 21 Feb 2024 18:20:49 +0000 [thread overview]
Message-ID: <87jzmxisqm.fsf@suse.de> (raw)
Hi!
The fstest generic/696 (and 697) fail on ext4 when the filesystem is
created with quota support (-O quota). It's really easy to reproduce, and
it fails when doing the idmapped tests (setgid_create_umask_idmapped() and
setgid_create_umask_idmapped_in_userns()).
The failure happens when the test does an openat() with O_TMPFILE:
ext4_tmpfile()
__ext4_new_inode()
dquot_initialize()
dqget()
and at this point the error occurs:
if (!qid_has_mapping(sb->s_user_ns, qid))
return ERR_PTR(-EINVAL);
qid is '-1', which is invalid, but I'm failing to understand if it should
really be invalid or if dqget() should handle this invalid qid some other
way. Earlier, __ext4_new_inode() called inode_init_owner(), which indeed
sets inode->i_uid with '-1'.
I've been trying to figure it out, but it's very tricky to follow all the
details, so I decided to ask here and see if anyone has any idea. Is this
a known issue? Maybe the issue is with the test itself, and not with
ext4, quota or idmapped code.
Cheers,
--
Luís
next reply other threads:[~2024-02-21 18:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 18:20 Luis Henriques [this message]
2024-02-22 13:23 ` [PATCH] vfs: fix check for tmpfile support Christian Brauner
2024-02-22 14:05 ` Luis Henriques
2024-02-25 15:56 ` Zorro Lang
2024-02-26 8:56 ` Luis Henriques
2024-02-22 13:26 ` fstest generic/696 failure on ext4 fs with quotas+idmap Christian Brauner
2024-02-22 13:53 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzmxisqm.fsf@suse.de \
--to=lhenriques@suse.de \
--cc=brauner@kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).