From: Kemeng Shi <shikemeng@huaweicloud.com>
To: Jan Kara <jack@suse.cz>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
ojaswin@linux.ibm.com, ritesh.list@gmail.com
Subject: Re: [PATCH v2 4/5] ext4: use correct criteria name instead stale integer number in comment
Date: Wed, 24 Apr 2024 09:20:15 +0800 [thread overview]
Message-ID: <383b74d7-3d9c-9140-29d7-b62023098c27@huaweicloud.com> (raw)
In-Reply-To: <20240423214352.t7yelmtvfbu7oggi@quack3>
on 4/24/2024 5:43 AM, Jan Kara wrote:
> On Tue 23-04-24 20:40:45, Kemeng Shi wrote:
>> Use correct criteria name instead stale integer number in comment
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>> Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
>
> You have cleaned up the superfluous "CR=" bits in several places but still
> left them is couple more :). See below:
Sorry, It seems that I mis-understand what you mean in last reply. I will
clean up all unnecessary stuff like "CR=" in next version. Thanks for the
feedback.
Kemeng
>
>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>> index 5acf413808a2..71b2f9a18875 100644
>> --- a/fs/ext4/mballoc.c
>> +++ b/fs/ext4/mballoc.c
>> @@ -1131,8 +1131,9 @@ static void ext4_mb_choose_next_group(struct ext4_allocation_context *ac,
>> ext4_mb_choose_next_group_best_avail(ac, new_cr, group);
>> } else {
>> /*
>> - * TODO: For CR=2, we can arrange groups in an rb tree sorted by
>> - * bb_free. But until that happens, we should never come here.
>> + * TODO: For CR=CR_GOAL_LEN_SLOW, we can arrange groups in an
> ^^^ Still you have left these superfluous
> "CR=" bits here.
>
>> + * rb tree sorted by bb_free. But until that happens, we should
>> + * never come here.
>> */
>> WARN_ON(1);
>> }
>> @@ -3445,10 +3446,11 @@ static int ext4_mb_init_backend(struct super_block *sb)
>> }
>> if (sbi->s_mb_prefetch > ext4_get_groups_count(sb))
>> sbi->s_mb_prefetch = ext4_get_groups_count(sb);
>> - /* now many real IOs to prefetch within a single allocation at cr=0
>> - * given cr=0 is an CPU-related optimization we shouldn't try to
>> - * load too many groups, at some point we should start to use what
>> - * we've got in memory.
>> + /*
>> + * now many real IOs to prefetch within a single allocation at
>> + * cr=CR_POWER2_ALIGNED. Given cr=CR_POWER2_ALIGNED is an CPU-related
> ^^^ and here ^^^
>
>> + * optimization we shouldn't try to load too many groups, at some point
>> + * we should start to use what we've got in memory.
>> * with an average random access time 5ms, it'd take a second to get
>> * 200 groups (* N with flex_bg), so let's make this limit 4
>> */
>
> Honza
>
next prev parent reply other threads:[~2024-04-24 1:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 12:40 [PATCH v2 0/5] Minor improvements and cleanups to ext4 mballoc Kemeng Shi
2024-04-23 12:40 ` [PATCH v2 1/5] ext4: keep "prefetch_grp" and "nr" consistent Kemeng Shi
2024-04-23 12:40 ` [PATCH v2 2/5] ext4: add test_mb_mark_used_cost to estimate cost of mb_mark_used Kemeng Shi
2024-04-23 12:40 ` [PATCH v2 3/5] ext4: call ext4_mb_mark_free_simple to free continuous bits in found chunk Kemeng Shi
2024-04-23 12:40 ` [PATCH v2 4/5] ext4: use correct criteria name instead stale integer number in comment Kemeng Shi
2024-04-23 21:43 ` Jan Kara
2024-04-24 1:20 ` Kemeng Shi [this message]
2024-04-23 12:40 ` [PATCH v2 5/5] ext4: open coding repeated check in next_linear_group Kemeng Shi
2024-04-23 21:46 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=383b74d7-3d9c-9140-29d7-b62023098c27@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).