From: Jan Kara <jack@suse.cz>
To: chengming.zhou@linux.dev
Cc: jack@suse.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
roman.gushchin@linux.dev, Xiongwei.Song@windriver.com,
Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH] ext2: remove SLAB_MEM_SPREAD flag usage
Date: Tue, 5 Mar 2024 15:12:21 +0100 [thread overview]
Message-ID: <20240305141221.um4zuvnro7tg5fgq@quack3> (raw)
In-Reply-To: <20240224134816.829424-1-chengming.zhou@linux.dev>
On Sat 24-02-24 13:48:16, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Thanks. I've added the patch to my tree.
Honza
> ---
> fs/ext2/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 6d8587505cea..7162c61c0402 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -213,8 +213,7 @@ static int __init init_inodecache(void)
> {
> ext2_inode_cachep = kmem_cache_create_usercopy("ext2_inode_cache",
> sizeof(struct ext2_inode_info), 0,
> - (SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
> - SLAB_ACCOUNT),
> + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
> offsetof(struct ext2_inode_info, i_data),
> sizeof_field(struct ext2_inode_info, i_data),
> init_once);
> --
> 2.40.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2024-03-05 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:48 [PATCH] ext2: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-03-05 14:12 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305141221.um4zuvnro7tg5fgq@quack3 \
--to=jack@suse.cz \
--cc=Xiongwei.Song@windriver.com \
--cc=chengming.zhou@linux.dev \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).