From: Eugen Hristev <eugen.hristev@collabora.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@collabora.com,
eugen.hristev@collabora.com, viro@zeniv.linux.org.uk,
brauner@kernel.org, jack@suse.cz, krisman@suse.de
Subject: [PATCH v12 0/8] Cache insensitive cleanup for ext4/f2fs
Date: Tue, 20 Feb 2024 10:52:27 +0200 [thread overview]
Message-ID: <20240220085235.71132-1-eugen.hristev@collabora.com> (raw)
Hello,
I am trying to respin the series here :
https://www.spinics.net/lists/linux-ext4/msg85081.html
I resent some of the v9 patches and got some reviews from Gabriel,
I did changes as requested and here is v12.
Changes in v12:
- revert to v10 comparison with propagating the error code from utf comparison
Changes in v11:
- revert to the original v9 implementation for the comparison helper.
Changes in v10:
- reworked a bit the comparison helper to improve performance by
first performing the exact lookup.
* Original commit letter
The case-insensitive implementations in f2fs and ext4 have quite a bit
of duplicated code. This series simplifies the ext4 version, with the
goal of extracting ext4_ci_compare into a helper library that can be
used by both filesystems. It also reduces the clutter from many
codeguards for CONFIG_UNICODE; as requested by Linus, they are part of
the codeflow now.
While there, I noticed we can leverage the utf8 functions to detect
encoded names that are corrupted in the filesystem. Therefore, it also
adds an ext4 error on that scenario, to mark the filesystem as
corrupted.
This series survived passes of xfstests -g quick.
Gabriel Krisman Bertazi (8):
ext4: Simplify the handling of cached insensitive names
f2fs: Simplify the handling of cached insensitive names
libfs: Introduce case-insensitive string comparison helper
ext4: Reuse generic_ci_match for ci comparisons
f2fs: Reuse generic_ci_match for ci comparisons
ext4: Log error when lookup of encoded dentry fails
ext4: Move CONFIG_UNICODE defguards into the code flow
f2fs: Move CONFIG_UNICODE defguards into the code flow
fs/ext4/crypto.c | 19 ++-----
fs/ext4/ext4.h | 35 +++++++-----
fs/ext4/namei.c | 129 ++++++++++++++++-----------------------------
fs/ext4/super.c | 4 +-
fs/f2fs/dir.c | 105 +++++++++++-------------------------
fs/f2fs/f2fs.h | 17 +++++-
fs/f2fs/namei.c | 10 ++--
fs/f2fs/recovery.c | 5 +-
fs/f2fs/super.c | 8 +--
fs/libfs.c | 85 +++++++++++++++++++++++++++++
include/linux/fs.h | 4 ++
11 files changed, 216 insertions(+), 205 deletions(-)
--
2.34.1
next reply other threads:[~2024-02-20 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 8:52 Eugen Hristev [this message]
2024-02-20 8:52 ` [PATCH v12 1/8] ext4: Simplify the handling of cached insensitive names Eugen Hristev
2024-02-20 8:52 ` [PATCH v12 2/8] f2fs: " Eugen Hristev
2024-02-27 23:11 ` Gabriel Krisman Bertazi
2024-02-20 8:52 ` [PATCH v12 3/8] libfs: Introduce case-insensitive string comparison helper Eugen Hristev
2024-02-27 23:32 ` Gabriel Krisman Bertazi
2024-02-20 8:52 ` [PATCH v12 4/8] ext4: Reuse generic_ci_match for ci comparisons Eugen Hristev
2024-02-20 8:52 ` [PATCH v12 5/8] f2fs: " Eugen Hristev
2024-02-20 8:52 ` [PATCH v12 6/8] ext4: Log error when lookup of encoded dentry fails Eugen Hristev
2024-02-27 23:38 ` Gabriel Krisman Bertazi
2024-02-20 8:52 ` [PATCH v12 7/8] ext4: Move CONFIG_UNICODE defguards into the code flow Eugen Hristev
2024-02-20 8:52 ` [PATCH v12 8/8] f2fs: " Eugen Hristev
2024-02-27 23:48 ` [PATCH v12 0/8] Cache insensitive cleanup for ext4/f2fs Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220085235.71132-1-eugen.hristev@collabora.com \
--to=eugen.hristev@collabora.com \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).