From: Anssi Hannula <anssi.hannula@iki.fi>
To: linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH e2fsprogs] resize2fs: avoid constantly flushing while moving blocks
Date: Tue, 7 Nov 2023 11:46:53 +0200 [thread overview]
Message-ID: <20231107094920.4056281-1-anssi.hannula@iki.fi> (raw)
resize2fs block_mover() flushes data after each extent and, curiously,
only if progress indicator is enabled, every inode_blocks_per_group
blocks.
This significantly affects performance, e.g. on a tested large
filesystem on top of MD-RAID6+LVM+dm-crypt these flush calls reduce the
operation rate from approx. 500MB/s to 5MB/s, causing extremely long
shrinking times for large size deltas (70TB in my case).
Since this step performs just plain data copying and does not e.g. save
any progress/checkpoint information or similar metadata, it seems like
this flushing is of very limited usefulness, especially when considering
the (in some cases) 100x performance impact.
Remove the mid-operation flushes and only flush after all blocks have
been moved.
Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
---
resize/resize2fs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/resize/resize2fs.c b/resize/resize2fs.c
index 5eeb7d44..46540501 100644
--- a/resize/resize2fs.c
+++ b/resize/resize2fs.c
@@ -1863,7 +1863,6 @@ static errcode_t block_mover(ext2_resize_t rfs)
old_blk += c;
moved += c;
if (rfs->progress) {
- io_channel_flush(fs->io);
retval = (rfs->progress)(rfs,
E2_RSZ_BLOCK_RELOC_PASS,
moved, to_move);
@@ -1871,9 +1870,10 @@ static errcode_t block_mover(ext2_resize_t rfs)
goto errout;
}
} while (size > 0);
- io_channel_flush(fs->io);
}
+ io_channel_flush(fs->io);
+
errout:
if (badblock_list) {
if (!retval && bb_modified)
--
2.41.0
next reply other threads:[~2023-11-07 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 9:46 Anssi Hannula [this message]
2024-04-17 4:33 ` [PATCH e2fsprogs] resize2fs: avoid constantly flushing while moving blocks Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107094920.4056281-1-anssi.hannula@iki.fi \
--to=anssi.hannula@iki.fi \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).