* [PATCH] ext4/053: Remove nouser_xattr test
@ 2022-08-17 3:10 Yang Xu
2022-08-28 2:48 ` Zorro Lang
0 siblings, 1 reply; 6+ messages in thread
From: Yang Xu @ 2022-08-17 3:10 UTC (permalink / raw
To: fstests; +Cc: jack, oliver.sang, lkp, linux-ext4, tytso, lczerner, Yang Xu
Plan to remove noacl and nouser_xattr mount option in kernel because they
are deprecated[1]. So remove nouser_xattr test in here.
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
tests/ext4/053 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/ext4/053 b/tests/ext4/053
index 555e474e..5d2c478a 100755
--- a/tests/ext4/053
+++ b/tests/ext4/053
@@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do
mnt oldalloc removed
mnt orlov removed
mnt -t user_xattr
- mnt nouser_xattr
if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then
mnt -t acl
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4/053: Remove nouser_xattr test
2022-08-17 3:10 [PATCH] ext4/053: Remove nouser_xattr test Yang Xu
@ 2022-08-28 2:48 ` Zorro Lang
2022-08-29 1:07 ` xuyang2018.jy
2022-08-29 10:06 ` Jan Kara
0 siblings, 2 replies; 6+ messages in thread
From: Zorro Lang @ 2022-08-28 2:48 UTC (permalink / raw
To: Yang Xu; +Cc: fstests, jack, oliver.sang, lkp, linux-ext4, tytso, lczerner
On Wed, Aug 17, 2022 at 11:10:23AM +0800, Yang Xu wrote:
> Plan to remove noacl and nouser_xattr mount option in kernel because they
> are deprecated[1]. So remove nouser_xattr test in here.
What's the [1]?
We'd better to be careful when we want to remove a testing coverage. I'm not
sure if they've decided to removed this mount option, the ext4/053 is an
important test case for ext4, so I'd like to hear their opinion.
Thanks,
Zorro
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> tests/ext4/053 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/ext4/053 b/tests/ext4/053
> index 555e474e..5d2c478a 100755
> --- a/tests/ext4/053
> +++ b/tests/ext4/053
> @@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do
> mnt oldalloc removed
> mnt orlov removed
> mnt -t user_xattr
> - mnt nouser_xattr
>
> if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then
> mnt -t acl
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4/053: Remove nouser_xattr test
2022-08-28 2:48 ` Zorro Lang
@ 2022-08-29 1:07 ` xuyang2018.jy
2022-08-29 10:06 ` Jan Kara
1 sibling, 0 replies; 6+ messages in thread
From: xuyang2018.jy @ 2022-08-29 1:07 UTC (permalink / raw
To: Zorro Lang
Cc: fstests@vger.kernel.org, jack@suse.cz, oliver.sang@intel.com,
lkp@intel.com, linux-ext4@vger.kernel.org, tytso@mit.edu,
lczerner@redhat.com
on 2022/08/28 10:48, Zorro Lang wrote:
> On Wed, Aug 17, 2022 at 11:10:23AM +0800, Yang Xu wrote:
>> Plan to remove noacl and nouser_xattr mount option in kernel because they
>> are deprecated[1]. So remove nouser_xattr test in here.
>
> What's the [1]?
>
> We'd better to be careful when we want to remove a testing coverage. I'm not
> sure if they've decided to removed this mount option, the ext4/053 is an
> important test case for ext4, so I'd like to hear their opinion.
Sorry for this miss.
[1]https://lore.kernel.org/linux-ext4/1658977369-2478-1-git-send-email-xuyang2018.jy@fujitsu.com/T/#t
Best Regards
Yang Xu
>
> Thanks,
> Zorro
>
>>
>> Reported-by: kernel test robot <oliver.sang@intel.com>
>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>> ---
>> tests/ext4/053 | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/ext4/053 b/tests/ext4/053
>> index 555e474e..5d2c478a 100755
>> --- a/tests/ext4/053
>> +++ b/tests/ext4/053
>> @@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do
>> mnt oldalloc removed
>> mnt orlov removed
>> mnt -t user_xattr
>> - mnt nouser_xattr
>>
>> if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then
>> mnt -t acl
>> --
>> 2.27.0
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4/053: Remove nouser_xattr test
2022-08-28 2:48 ` Zorro Lang
2022-08-29 1:07 ` xuyang2018.jy
@ 2022-08-29 10:06 ` Jan Kara
2022-08-31 9:31 ` Zorro Lang
1 sibling, 1 reply; 6+ messages in thread
From: Jan Kara @ 2022-08-29 10:06 UTC (permalink / raw
To: Zorro Lang
Cc: Yang Xu, fstests, jack, oliver.sang, lkp, linux-ext4, tytso,
lczerner
On Sun 28-08-22 10:48:58, Zorro Lang wrote:
> On Wed, Aug 17, 2022 at 11:10:23AM +0800, Yang Xu wrote:
> > Plan to remove noacl and nouser_xattr mount option in kernel because they
> > are deprecated[1]. So remove nouser_xattr test in here.
>
> What's the [1]?
>
> We'd better to be careful when we want to remove a testing coverage. I'm not
> sure if they've decided to removed this mount option, the ext4/053 is an
> important test case for ext4, so I'd like to hear their opinion.
Yes, the option is long deprecated and we want to remove it from ext4. But
I think you might want to see official ack from Ted as a maintainer on this
:). Ted?
Honza
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > ---
> > tests/ext4/053 | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/ext4/053 b/tests/ext4/053
> > index 555e474e..5d2c478a 100755
> > --- a/tests/ext4/053
> > +++ b/tests/ext4/053
> > @@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do
> > mnt oldalloc removed
> > mnt orlov removed
> > mnt -t user_xattr
> > - mnt nouser_xattr
> >
> > if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then
> > mnt -t acl
> > --
> > 2.27.0
> >
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4/053: Remove nouser_xattr test
2022-08-29 10:06 ` Jan Kara
@ 2022-08-31 9:31 ` Zorro Lang
2022-08-31 10:37 ` Jan Kara
0 siblings, 1 reply; 6+ messages in thread
From: Zorro Lang @ 2022-08-31 9:31 UTC (permalink / raw
To: Jan Kara; +Cc: Yang Xu, fstests, oliver.sang, lkp, linux-ext4, tytso, lczerner
On Mon, Aug 29, 2022 at 12:06:57PM +0200, Jan Kara wrote:
> On Sun 28-08-22 10:48:58, Zorro Lang wrote:
> > On Wed, Aug 17, 2022 at 11:10:23AM +0800, Yang Xu wrote:
> > > Plan to remove noacl and nouser_xattr mount option in kernel because they
> > > are deprecated[1]. So remove nouser_xattr test in here.
> >
> > What's the [1]?
> >
> > We'd better to be careful when we want to remove a testing coverage. I'm not
> > sure if they've decided to removed this mount option, the ext4/053 is an
> > important test case for ext4, so I'd like to hear their opinion.
>
> Yes, the option is long deprecated and we want to remove it from ext4. But
> I think you might want to see official ack from Ted as a maintainer on this
> :). Ted?
It's fine for me, if anyone stand for ext4 list to give this patch a RVB, due
to it's not a bug fix or new testing, it's a testing deduction, and only affect
ext4 testing.
Thanks,
Zorro
>
> Honza
>
> > > Reported-by: kernel test robot <oliver.sang@intel.com>
> > > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > > ---
> > > tests/ext4/053 | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/tests/ext4/053 b/tests/ext4/053
> > > index 555e474e..5d2c478a 100755
> > > --- a/tests/ext4/053
> > > +++ b/tests/ext4/053
> > > @@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do
> > > mnt oldalloc removed
> > > mnt orlov removed
> > > mnt -t user_xattr
> > > - mnt nouser_xattr
> > >
> > > if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then
> > > mnt -t acl
> > > --
> > > 2.27.0
> > >
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4/053: Remove nouser_xattr test
2022-08-31 9:31 ` Zorro Lang
@ 2022-08-31 10:37 ` Jan Kara
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kara @ 2022-08-31 10:37 UTC (permalink / raw
To: Zorro Lang
Cc: Jan Kara, Yang Xu, fstests, oliver.sang, lkp, linux-ext4, tytso,
lczerner
On Wed 31-08-22 17:31:48, Zorro Lang wrote:
> On Mon, Aug 29, 2022 at 12:06:57PM +0200, Jan Kara wrote:
> > On Sun 28-08-22 10:48:58, Zorro Lang wrote:
> > > On Wed, Aug 17, 2022 at 11:10:23AM +0800, Yang Xu wrote:
> > > > Plan to remove noacl and nouser_xattr mount option in kernel because they
> > > > are deprecated[1]. So remove nouser_xattr test in here.
> > >
> > > What's the [1]?
> > >
> > > We'd better to be careful when we want to remove a testing coverage. I'm not
> > > sure if they've decided to removed this mount option, the ext4/053 is an
> > > important test case for ext4, so I'd like to hear their opinion.
> >
> > Yes, the option is long deprecated and we want to remove it from ext4. But
> > I think you might want to see official ack from Ted as a maintainer on this
> > :). Ted?
>
> It's fine for me, if anyone stand for ext4 list to give this patch a RVB, due
> to it's not a bug fix or new testing, it's a testing deduction, and only affect
> ext4 testing.
Sure, feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> > > > Reported-by: kernel test robot <oliver.sang@intel.com>
> > > > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > > > ---
> > > > tests/ext4/053 | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/tests/ext4/053 b/tests/ext4/053
> > > > index 555e474e..5d2c478a 100755
> > > > --- a/tests/ext4/053
> > > > +++ b/tests/ext4/053
> > > > @@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do
> > > > mnt oldalloc removed
> > > > mnt orlov removed
> > > > mnt -t user_xattr
> > > > - mnt nouser_xattr
> > > >
> > > > if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then
> > > > mnt -t acl
> > > > --
> > > > 2.27.0
> > > >
> > >
> > --
> > Jan Kara <jack@suse.com>
> > SUSE Labs, CR
> >
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-31 10:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-17 3:10 [PATCH] ext4/053: Remove nouser_xattr test Yang Xu
2022-08-28 2:48 ` Zorro Lang
2022-08-29 1:07 ` xuyang2018.jy
2022-08-29 10:06 ` Jan Kara
2022-08-31 9:31 ` Zorro Lang
2022-08-31 10:37 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).