From: Chengming Zhou <chengming.zhou@linux.dev>
To: xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com,
jefflexu@linux.alibaba.com
Cc: Xiongwei.Song@windriver.com, linux-erofs@lists.ozlabs.org,
linux-kernel@vger.kernel.org, vbabka@suse.cz
Subject: Re: [PATCH] erofs: remove SLAB_MEM_SPREAD flag usage
Date: Mon, 26 Feb 2024 16:57:31 +0800 [thread overview]
Message-ID: <f4b7e424-8f43-4940-89f0-cdfffbf6bb4c@linux.dev> (raw)
In-Reply-To: <20240224134749.829361-1-chengming.zhou@linux.dev>
On 2024/2/24 21:47, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete explicitly to avoid confusion
for users. Here we can just remove all its users, which has no any
functional change.
[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
Thanks!
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
> fs/erofs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 9b4b66dcdd4f..8b6bf9ae1a59 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -885,7 +885,7 @@ static int __init erofs_module_init(void)
>
> erofs_inode_cachep = kmem_cache_create("erofs_inode",
> sizeof(struct erofs_inode), 0,
> - SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT,
> + SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
> erofs_inode_init_once);
> if (!erofs_inode_cachep)
> return -ENOMEM;
prev parent reply other threads:[~2024-02-26 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:47 [PATCH] erofs: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-26 8:57 ` Chengming Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b7e424-8f43-4940-89f0-cdfffbf6bb4c@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=Xiongwei.Song@windriver.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).