From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Chunhai Guo <guochunhai@vivo.com>, xiang@kernel.org
Cc: linux-erofs@lists.ozlabs.org, huyue2@coolpad.com
Subject: Re: [PATCH v3] erofs: rename per CPU buffer to global buffer pool and make it configurable
Date: Fri, 22 Mar 2024 21:45:58 +0800 [thread overview]
Message-ID: <bfb383a6-de23-4fdf-805b-09f8630f056e@linux.alibaba.com> (raw)
In-Reply-To: <20240322134540.1118625-1-guochunhai@vivo.com>
On 2024/3/22 21:45, Chunhai Guo wrote:
> It will cost more time if compressed buffers are allocated on demand for
> low-latency algorithms (like lz4) so EROFS uses per-CPU buffers to keep
> compressed data if in-place decompression is unfulfilled. While it is kind
> of wasteful of memory for a device with hundreds of CPUs, and only a small
> number of CPUs concurrently decompress most of the time.
>
> This patch renames it as 'global buffer pool' and makes it configurable.
> This allows two or more CPUs to share a common buffer to reduce memory
> occupation.
>
> Signed-off-by: Chunhai Guo <guochunhai@vivo.com>
> Suggested-by: Gao Xiang <xiang@kernel.org>
> ---
Side note: it'd be better to have a changelog here against the previous
version next time.
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
prev parent reply other threads:[~2024-03-22 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 13:45 [PATCH v3] erofs: rename per CPU buffer to global buffer pool and make it configurable Chunhai Guo via Linux-erofs
2024-03-22 13:45 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfb383a6-de23-4fdf-805b-09f8630f056e@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=guochunhai@vivo.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).