From: Hongzhen Luo <hongzhen@linux.alibaba.com>
To: Jingbo Xu <jefflexu@linux.alibaba.com>,
xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: huyue2@coolpad.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: derive fsid from on-disk UUID for .statfs() if possible
Date: Tue, 9 Apr 2024 19:23:09 +0800 [thread overview]
Message-ID: <b052bf53-237f-4693-a5e4-b50d914db5fc@linux.alibaba.com> (raw)
In-Reply-To: <46253829-689c-4f06-8d08-a999c0ddbd1b@linux.alibaba.com>
在 2024/4/9 17:36, Jingbo Xu 写道:
>
> On 4/9/24 4:11 PM, Hongzhen Luo wrote:
>> Use the superblock's UUID to generate the fsid when it's non-null.
>>
>> Signed-off-by: Hongzhen Luo <hongzhen@linux.alibaba.com>
>> ---
>> fs/erofs/super.c | 12 +++++-------
>> 1 file changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
>> index c0eb139adb07..83bd8ee3b5ba 100644
>> --- a/fs/erofs/super.c
>> +++ b/fs/erofs/super.c
>> @@ -923,22 +923,20 @@ static int erofs_statfs(struct dentry *dentry, struct kstatfs *buf)
>> {
>> struct super_block *sb = dentry->d_sb;
>> struct erofs_sb_info *sbi = EROFS_SB(sb);
>> - u64 id = 0;
>> -
>> - if (!erofs_is_fscache_mode(sb))
>> - id = huge_encode_dev(sb->s_bdev->bd_dev);
>>
>> buf->f_type = sb->s_magic;
>> buf->f_bsize = sb->s_blocksize;
>> buf->f_blocks = sbi->total_blocks;
>> buf->f_bfree = buf->f_bavail = 0;
>> -
>> buf->f_files = ULLONG_MAX;
>> buf->f_ffree = ULLONG_MAX - sbi->inos;
>> -
>> buf->f_namelen = EROFS_NAME_LEN;
>>
>> - buf->f_fsid = u64_to_fsid(id);
>> + if (uuid_is_null(&sb->s_uuid))
>> + buf->f_fsid = u64_to_fsid(erofs_is_fscache_mode(sb) ? 0 :
>> + huge_encode_dev(sb->s_bdev->bd_dev));
>> + else
>> + buf->f_fsid = uuid_to_fsid((__u8 *)&sb->s_uuid);
> How about
>
> buf->f_fsid = uuid_to_fsid(sb->s_uuid.b);
>
> which looks cleaner.
>
> Otherwise LGTM.
>
> Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
>
>
Thanks. I will send v2 later.
---
Hongzhen
prev parent reply other threads:[~2024-04-09 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 8:11 [PATCH] erofs: derive fsid from on-disk UUID for .statfs() if possible Hongzhen Luo
2024-04-09 8:47 ` Gao Xiang
2024-04-09 9:36 ` Jingbo Xu
2024-04-09 11:23 ` Hongzhen Luo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b052bf53-237f-4693-a5e4-b50d914db5fc@linux.alibaba.com \
--to=hongzhen@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).