From: Noboru Asai <asai@sijam.com>
To: Noboru Asai <asai@sijam.com>, Yifan Zhao <zhaoyifan@sjtu.edu.cn>,
Gao Xiang <hsiangkao@linux.alibaba.com>,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: mkfs: skip the redundant write for ztailpacking block
Date: Thu, 18 Apr 2024 14:52:28 +0900 [thread overview]
Message-ID: <CAFoAo-KZG8MEbSHaf2LrRdoj1MsjbvWFTcaeaZy5UuNqKNJ-HA@mail.gmail.com> (raw)
In-Reply-To: <ZiCoVYoxW7NFHeUr@debian>
Hi Gao,
I made a patch set and send it. I'm grad that this patch set help your thinking.
2024年4月18日(木) 13:58 Gao Xiang <xiang@kernel.org>:
>
> Hi Noboru,
>
> On Thu, Apr 18, 2024 at 10:09:22AM +0900, Noboru Asai wrote:
> > In this patch, the value of blkaddr in z_erofs_lcluster_index
> > corresponding to the ztailpacking block in the extent list
> > is invalid value. It looks that the linux kernel doesn't refer to this
> > value, but what value is correct?
> > 0 or -1 (EROFS_NULL_ADDR) or don't care?
>
> Thanks for pointing out!
>
> On the kernel side, it doesn't care this value if it's really
> _inlined_.
>
> But on the mkfs side, since we have inline fallback so I don't
> think an invalid blkaddr is correct. The next blkaddr should
> be filled for inline fallback instead.
>
> Let me think more about it and update the patch.
>
> Thanks,
> Gao Xiang
next prev parent reply other threads:[~2024-04-18 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 14:42 [PATCH] erofs-utils: mkfs: skip the redundant write for ztailpacking block Yifan Zhao
2024-04-18 1:09 ` Noboru Asai
2024-04-18 4:57 ` Gao Xiang
2024-04-18 5:52 ` Noboru Asai [this message]
2024-04-18 5:03 ` Yifan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFoAo-KZG8MEbSHaf2LrRdoj1MsjbvWFTcaeaZy5UuNqKNJ-HA@mail.gmail.com \
--to=asai@sijam.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=zhaoyifan@sjtu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).