From: Noboru Asai <asai@sijam.com>
To: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v3 0/4] erofs-utils: mkfs: introduce multi-threaded compression
Date: Thu, 29 Feb 2024 18:34:01 +0900 [thread overview]
Message-ID: <CAFoAo-KCoKneBm2F-didrKGKGVu--A0JH3gNqV0weanVwgScUw@mail.gmail.com> (raw)
In-Reply-To: <a59dfa27-0961-472a-b7ed-57769123d430@sjtu.edu.cn>
> We split the inter-file compression functionality as a separate patch
> set for ease of review. It will be re-sent shortly (maybe a few days)
> after we finish polishing the inner-file patch set.
>
> I am sorry that the v2 patchset cannot be cleanly applied due to my
> missteps, and I believe the latest one (v4) works. Thank you for your
> testing!
Thank you your explanation. I will test v4 and review it.
2024年2月29日(木) 13:33 Yifan Zhao <zhaoyifan@sjtu.edu.cn>:
>
>
> On 2/29/24 11:12, Noboru Asai wrote:
> >> - remove inter-file compression support from this patchset
> > Do you have any problems about inter-file compression functionarity?
> > Or make steps (split this functionarity as separate patch set)?
> > I'm testing v1 patch set and I have no problem like making wrong images for now.
> > (I couldn't apply v2 patch set without rejects.)
> >
> > 2024年2月25日(日) 23:28 Yifan Zhao <zhaoyifan@sjtu.edu.cn>:
> >
> We split the inter-file compression functionality as a separate patch
> set for ease of review. It will be re-sent shortly (maybe a few days)
> after we finish polishing the inner-file patch set.
>
> I am sorry that the v2 patchset cannot be cleanly applied due to my
> missteps, and I believe the latest one (v4) works. Thank you for your
> testing!
>
>
> Thanks,
>
> Yifan Zhao
>
> >> change log since v2:
> >> - squash per-worker tmpfile commit into previous PATCH
> >> - give static global variable `erofs_` prefix
> >> - remove inter-file compression support from this patchset
> >> - introduce a new `z_erofs_file_compress_ctx` struct to divide the segment
> >> context from the file context
> >> - remove the patch related to pring warning from this patchset, which may be
> >> supported later with atomic variables
> >>
> >> Gao Xiang (1):
> >> erofs-utils: add a helper to get available processors
> >>
> >> Yifan Zhao (3):
> >> erofs-utils: introduce multi-threading framework
> >> erofs-utils: mkfs: add --worker=# parameter
> >> erofs-utils: mkfs: introduce inner-file multi-threaded compression
> >>
> >> configure.ac | 17 +
> >> include/erofs/compress.h | 1 +
> >> include/erofs/config.h | 5 +
> >> include/erofs/internal.h | 3 +
> >> include/erofs/workqueue.h | 37 ++
> >> lib/Makefile.am | 4 +
> >> lib/compress.c | 690 +++++++++++++++++++++++++++++++-------
> >> lib/compressor.c | 2 +
> >> lib/config.c | 16 +
> >> lib/workqueue.c | 132 ++++++++
> >> mkfs/main.c | 38 +++
> >> 11 files changed, 827 insertions(+), 118 deletions(-)
> >> create mode 100644 include/erofs/workqueue.h
> >> create mode 100644 lib/workqueue.c
> >>
> >> --
> >> 2.44.0
> >>
prev parent reply other threads:[~2024-02-29 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 14:27 [PATCH v3 0/4] erofs-utils: mkfs: introduce multi-threaded compression Yifan Zhao
2024-02-25 14:27 ` [PATCH v3 1/4] erofs-utils: introduce multi-threading framework Yifan Zhao
2024-02-25 14:27 ` [PATCH v3 2/4] erofs-utils: add a helper to get available processors Yifan Zhao
2024-02-25 14:27 ` [PATCH v3 3/4] erofs-utils: mkfs: add --worker=# parameter Yifan Zhao
2024-02-25 14:27 ` [PATCH v3 4/4] erofs-utils: mkfs: introduce inner-file multi-threaded compression Yifan Zhao
2024-02-28 9:57 ` Gao Xiang
2024-02-28 15:13 ` Yifan Zhao
2024-02-28 15:38 ` Gao Xiang
2024-02-29 3:12 ` [PATCH v3 0/4] erofs-utils: mkfs: introduce " Noboru Asai
2024-02-29 4:33 ` Yifan Zhao
2024-02-29 9:34 ` Noboru Asai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFoAo-KCoKneBm2F-didrKGKGVu--A0JH3gNqV0weanVwgScUw@mail.gmail.com \
--to=asai@sijam.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=zhaoyifan@sjtu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).