From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Sandeep Dhavale <dhavale@google.com>
Cc: kernel-team@android.com, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v1] erofs-utils: dump: print filesystem blocksize
Date: Sat, 13 Apr 2024 09:02:22 +0800 [thread overview]
Message-ID: <9fe4a34c-d291-4e83-966d-8e07f21d7100@linux.alibaba.com> (raw)
In-Reply-To: <CAB=BE-RsPmjGgWKmuguTYQzkmmxGLdrqvaGcBFWA--AcsUr8sQ@mail.gmail.com>
On 2024/4/13 09:00, Sandeep Dhavale wrote:
> On Fri, Apr 12, 2024 at 5:09 PM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>>
>> Hi Sandeep,
>>
>> On 2024/4/13 06:51, Sandeep Dhavale wrote:
>>> mkfs.erofs supports creating filesystem images with different
>>> blocksizes. Add filesystem blocksize in super block dump so
>>> its easier to inspect the filesystem.
>>>
>>> The filed is added at last, so the output now looks like:
>>>
>>> Filesystem magic number: 0xE0F5E1E2
>>> Filesystem blocks: 21
>>> Filesystem inode metadata start block: 0
>>> Filesystem shared xattr metadata start block: 0
>>> Filesystem root nid: 36
>>> Filesystem lz4_max_distance: 65535
>>> Filesystem sb_extslots: 0
>>> Filesystem inode count: 10
>>> Filesystem created: Fri Apr 12 15:43:40 2024
>>> Filesystem features: sb_csum mtime 0padding
>>> Filesystem UUID: a84a2acc-08d8-4b72-8b8c-b811a815fa07
>>> Filesystem blocksize: 65536
>>>
>>> Signed-off-by: Sandeep Dhavale <dhavale@google.com>
>>
>> Just a minor nit:
>> Could we move "Filesystem blocksize:" between the line of
>> "Filesystem magic number:" and "Filesystem blocks:" ?
>>
>> Otherwise it looks good to me, thanks for this!
>>
> Hi Gao,
> Sure I can change the location. I didn't do it assuming someone might
> have scripted around it (not that I know of!), so I added it last.
Yeah, I could guess your original intentation. But it seems somewhat
strange to show `Filesystem blocksize` in the very end...
Thanks,
Gao Xiang
> I will send V2 by moving it after magic number.
>
> Thanks,
> Sandeep.
>> Thanks,
>> Gao Xiang
prev parent reply other threads:[~2024-04-13 1:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 22:51 [PATCH v1] erofs-utils: dump: print filesystem blocksize Sandeep Dhavale via Linux-erofs
2024-04-13 0:08 ` Gao Xiang
2024-04-13 1:00 ` Sandeep Dhavale via Linux-erofs
2024-04-13 1:02 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe4a34c-d291-4e83-966d-8e07f21d7100@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=dhavale@google.com \
--cc=kernel-team@android.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).