From: Hongbo Li via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, <xiang@kernel.org>,
<chao@kernel.org>
Cc: huyue2@coolpad.com,
linux-erofs mailing list <linux-erofs@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed
Date: Wed, 24 Apr 2024 16:44:27 +0800 [thread overview]
Message-ID: <7ae4a071-56b3-410b-9c95-d6677dc46f25@huawei.com> (raw)
In-Reply-To: <871467f7-1218-4c13-ae47-13e89bbbe0cc@linux.alibaba.com>
ok, thanks!
On 2024/4/24 11:29, Gao Xiang wrote:
>
> (+cc linux-erofs & LKML)
>
> On 2024/4/24 10:39, Hongbo Li wrote:
>> When prepare_ondemand_read failed, wrong error message is printed.
>> The prepare_read is also implemented in cachefiles, so we amend it.
>>
>> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
>
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>
> Could you resend the patch with proper mailing list cced with my
> "reviewed-by:" tag? So I could apply with "b4" tool.
>
> Thanks,
> Gao Xiang
>
>> ---
>> fs/erofs/fscache.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
>> index 8aff1a724805..62da538d91cb 100644
>> --- a/fs/erofs/fscache.c
>> +++ b/fs/erofs/fscache.c
>> @@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct
>> fscache_cookie *cookie,
>> if (WARN_ON(len == 0))
>> source = NETFS_INVALID_READ;
>> if (source != NETFS_READ_FROM_CACHE) {
>> - erofs_err(NULL, "prepare_read failed (source %d)", source);
>> + erofs_err(NULL, "prepare_ondemand_read failed (source
>> %d)", source);
>> return -EIO;
>> }
next prev parent reply other threads:[~2024-04-24 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240424023945.420828-1-lihongbo22@huawei.com>
2024-04-24 3:29 ` [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed Gao Xiang
2024-04-24 8:44 ` Hongbo Li via Linux-erofs [this message]
2024-04-24 8:42 Hongbo Li via Linux-erofs
2024-04-24 11:21 ` Jingbo Xu
2024-04-28 6:23 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ae4a071-56b3-410b-9c95-d6677dc46f25@huawei.com \
--to=linux-erofs@lists.ozlabs.org \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=lihongbo22@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).