From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Yifan Zhao <zhaoyifan@sjtu.edu.cn>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: add preliminary zstd support
Date: Thu, 9 May 2024 18:06:31 +0800 [thread overview]
Message-ID: <5de3b4ea-c096-4b0e-80c1-ac5785fd1869@linux.alibaba.com> (raw)
In-Reply-To: <ab9bf1a7-6ea1-4a93-a21f-decfde503fe1@sjtu.edu.cn>
On 2024/5/9 17:53, Yifan Zhao wrote:
> Hi Gao,
>
> I found this zstd implementation failed in my smoking test[1] with -Eall-fragments and -Eztailpacking enabled. You could reproduce it with enwik8 workload.
>
> After a galance I notice that libzstd_compress_destsize() may return a value larger than `dstsize`. I mark it in the code below.
That is expected.
>
> I believe this will break the assumption in its caller and lead to broken image.
>
> However I'm not an expert of zstd algorithms, could you please take a look at it?
>
>
> [1] https://github.com/SToPire/erofsnightly/actions/runs/9004052391
>
I will look into that, thanks!
Thanks,
Gao Xiang
prev parent reply other threads:[~2024-05-09 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 9:58 [PATCH] erofs-utils: add preliminary zstd support Gao Xiang
2024-05-09 5:50 ` [PATCH v2] erofs-utils: add preliminary zstd support [x] Gao Xiang
2024-05-09 15:39 ` [PATCH v3] " Gao Xiang
2024-05-15 5:16 ` Gao Xiang
2024-05-09 9:53 ` [PATCH] erofs-utils: add preliminary zstd support Yifan Zhao
2024-05-09 10:06 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de3b4ea-c096-4b0e-80c1-ac5785fd1869@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=zhaoyifan@sjtu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).