From: Baokun Li via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Christian Brauner <brauner@kernel.org>, <xiang@kernel.org>
Cc: yangerkun@huawei.com, linux-kernel@vger.kernel.org,
huyue2@coolpad.com, viro@zeniv.linux.org.uk,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs: set SB_NODEV sb_flags when mounting with fsid
Date: Wed, 17 Apr 2024 11:26:18 +0800 [thread overview]
Message-ID: <47247f78-eafb-cb4f-495f-e91a647c3f3c@huawei.com> (raw)
In-Reply-To: <Zh898uJW0AFtE0Rk@debian>
On 2024/4/17 11:11, Gao Xiang wrote:
> On Wed, Apr 17, 2024 at 10:59:53AM +0800, Baokun Li wrote:
>> On 2024/4/16 22:49, Gao Xiang wrote:
>>> On Tue, Apr 16, 2024 at 02:35:08PM +0200, Christian Brauner wrote:
>>>>>> I'm not sure how to resolve it in EROFS itself, anyway...
>>>> Instead of allocating the erofs_sb_info in fill_super() allocate it
>>>> during erofs_get_tree() and then you can ensure that you always have the
>>>> info you need available during erofs_kill_sb(). See the appended
>>>> (untested) patch.
>>> Hi Christian,
>>>
>>> Yeah, that is a good way I think. Although sbi will be allocated
>>> unconditionally instead but that is minor.
>>>
>>> I'm on OSSNA this week, will test this patch more when returning.
>>>
>>> Hi Baokun,
>>>
>>> Could you also check this on your side?
>>>
>>> Thanks,
>>> Gao Xiang
>> Hi Xiang,
>>
>> This patch does fix the initial problem.
>>
>>
>> Hi Christian,
>>
>> Thanks for the patch, this is a good idea. Just with nits below.
>> Otherwise feel free to add.
>>
>> Reviewed-and-tested-by: Baokun Li <libaokun1@huawei.com>
>>>> From e4f586a41748b6edc05aca36d49b7b39e55def81 Mon Sep 17 00:00:00 2001
>>>> From: Christian Brauner <brauner@kernel.org>
>>>> Date: Mon, 15 Apr 2024 20:17:46 +0800
>>>> Subject: [PATCH] erofs: reliably distinguish block based and fscache mode
>>>>
>> SNIP
>>
>>>> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
>>>> index c0eb139adb07..4ed80154edf8 100644
>>>> --- a/fs/erofs/super.c
>>>> +++ b/fs/erofs/super.c
>>>> @@ -581,7 +581,7 @@ static const struct export_operations erofs_export_ops = {
>>>> static int erofs_fc_fill_super(struct super_block *sb, struct fs_context *fc)
>>>> {
>>>> struct inode *inode;
>>>> - struct erofs_sb_info *sbi;
>>>> + struct erofs_sb_info *sbi = EROFS_SB(sb);
>>>> struct erofs_fs_context *ctx = fc->fs_private;
>>>> int err;
>>>> @@ -590,15 +590,10 @@ static int erofs_fc_fill_super(struct super_block *sb, struct fs_context *fc)
>>>> sb->s_maxbytes = MAX_LFS_FILESIZE;
>>>> sb->s_op = &erofs_sops;
>>>> - sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
>>>> - if (!sbi)
>>>> - return -ENOMEM;
>>>> -
>>>> sb->s_fs_info = sbi;
>> This line is no longer needed.
>>>> sbi->opt = ctx->opt;
>>>> sbi->devs = ctx->devs;
>>>> ctx->devs = NULL;
>>>> - sbi->fsid = ctx->fsid;
>>>> ctx->fsid = NULL;
>>>> sbi->domain_id = ctx->domain_id;
>>>> ctx->domain_id = NULL;
>> Since erofs_sb_info is now allocated in erofs_fc_get_tree(), why not
>> encapsulate the above lines as erofs_ctx_to_info() helper function
>> to be called in erofs_fc_get_tree()？Then erofs_fc_fill_super() wouldn't
>> have to use erofs_fs_context and would prevent the fsid from being
>> freed twice.
> Hi Baokun,
>
> I'm not sure if Christian has enough time to polish the whole
> codebase (I'm happy if do so). Basically, that is just a hint
> to the issue, if you have more time, I guess you could also help
> revive this patch together (also because you also have a real
> EROFS test environment).
>
> Let me also check this next week after OSSNA travelling.
>
> Thanks,
> Gao Xiang
Hi Xiang,
Ok, then I will polish the patch and send it out as a v2.
Thanks,
Baokun
prev parent reply other threads:[~2024-04-17 3:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 12:17 [PATCH] erofs: set SB_NODEV sb_flags when mounting with fsid Baokun Li via Linux-erofs
2024-04-15 13:38 ` Christian Brauner
2024-04-15 14:08 ` Baokun Li via Linux-erofs
2024-04-15 15:23 ` Baokun Li via Linux-erofs
2024-04-16 0:57 ` Gao Xiang
2024-04-16 1:36 ` Baokun Li via Linux-erofs
2024-04-16 12:35 ` Christian Brauner
2024-04-16 14:49 ` Gao Xiang
2024-04-17 2:59 ` Baokun Li via Linux-erofs
2024-04-17 3:11 ` Gao Xiang
2024-04-17 3:26 ` Baokun Li via Linux-erofs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47247f78-eafb-cb4f-495f-e91a647c3f3c@huawei.com \
--to=linux-erofs@lists.ozlabs.org \
--cc=brauner@kernel.org \
--cc=huyue2@coolpad.com \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).