From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: set opaque flag for directories in tarerofs mode
Date: Tue, 2 Apr 2024 13:51:47 +0800 [thread overview]
Message-ID: <214a8e00-377c-421e-bdbf-2711bbb49c80@linux.alibaba.com> (raw)
In-Reply-To: <20240402025858.1729161-1-hsiangkao@linux.alibaba.com>
On 4/2/24 10:58 AM, Gao Xiang wrote:
> Opaque dir flag is needed if the tar tree is used immediately for
> the upcoming append mode.
>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> lib/tar.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/tar.c b/lib/tar.c
> index 7c271f6..b45657d 100644
> --- a/lib/tar.c
> +++ b/lib/tar.c
> @@ -909,6 +909,11 @@ restart:
> } else if (opq) {
> DBG_BUGON(d->type == EROFS_FT_UNKNOWN);
> DBG_BUGON(!d->inode);
> + /*
> + * needed if the tar tree is used soon, thus we have no chance
> + * to generate it from xattrs. No impact to mergefs.
> + */
> + d->inode->opaque = true;
> ret = erofs_set_opaque_xattr(d->inode);
> goto out;
> } else if (th->typeflag == '1') { /* hard link cases */
LGTM.
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
--
Thanks,
Jingbo
prev parent reply other threads:[~2024-04-02 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 2:58 [PATCH] erofs-utils: set opaque flag for directories in tarerofs mode Gao Xiang
2024-04-02 5:51 ` Jingbo Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=214a8e00-377c-421e-bdbf-2711bbb49c80@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).