From: libaokun@huaweicloud.com
To: netfs@lists.linux.dev
Cc: libaokun@huaweicloud.com, jlayton@kernel.org,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com,
linux-erofs@lists.ozlabs.org
Subject: [PATCH 2/5] cachefiles: flush all requests for the object that is being dropped
Date: Wed, 24 Apr 2024 11:34:06 +0800 [thread overview]
Message-ID: <20240424033409.2735257-3-libaokun@huaweicloud.com> (raw)
In-Reply-To: <20240424033409.2735257-1-libaokun@huaweicloud.com>
From: Baokun Li <libaokun1@huawei.com>
Because after an object is dropped, requests for that object are useless,
flush them to avoid causing other problems.
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
fs/cachefiles/ondemand.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
index 73da4d4eaa9b..d24bff43499b 100644
--- a/fs/cachefiles/ondemand.c
+++ b/fs/cachefiles/ondemand.c
@@ -564,12 +564,31 @@ int cachefiles_ondemand_init_object(struct cachefiles_object *object)
void cachefiles_ondemand_clean_object(struct cachefiles_object *object)
{
+ unsigned long index;
+ struct cachefiles_req *req;
+ struct cachefiles_cache *cache;
+
if (!object->ondemand)
return;
cachefiles_ondemand_send_req(object, CACHEFILES_OP_CLOSE, 0,
cachefiles_ondemand_init_close_req, NULL);
+
+ if (!object->ondemand->ondemand_id)
+ return;
+
+ /* Flush all requests for the object that is being dropped. */
+ cache = object->volume->cache;
+ xa_lock(&cache->reqs);
cachefiles_ondemand_set_object_dropping(object);
+ xa_for_each(&cache->reqs, index, req) {
+ if (req->object == object) {
+ req->error = -EIO;
+ complete(&req->done);
+ __xa_erase(&cache->reqs, index);
+ }
+ }
+ xa_unlock(&cache->reqs);
}
int cachefiles_ondemand_init_obj_info(struct cachefiles_object *object,
--
2.39.2
next prev parent reply other threads:[~2024-04-24 3:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 3:34 [PATCH 0/5] cachefiles: some bugfixes for clean object/send req/poll libaokun
2024-04-24 3:34 ` [PATCH 1/5] cachefiles: stop sending new request when dropping object libaokun
2024-04-24 3:34 ` libaokun [this message]
2024-04-24 3:34 ` [PATCH 3/5] cachefiles: flush ondemand_object_worker during clean object libaokun
2024-04-25 5:41 ` Jia Zhu via Linux-erofs
2024-04-25 6:53 ` Baokun Li
2024-04-24 3:34 ` [PATCH 4/5] cachefiles: cyclic allocation of msg_id to avoid reuse libaokun
2024-04-24 3:34 ` [PATCH 5/5] cachefiles: add missing lock protection when polling libaokun
2024-04-24 4:29 ` Gao Xiang
2024-04-24 6:23 ` Baokun Li
2024-04-24 5:46 ` Jia Zhu via Linux-erofs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424033409.2735257-3-libaokun@huaweicloud.com \
--to=libaokun@huaweicloud.com \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).