From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Chao Yu <chao@kernel.org>, linux-erofs@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP
Date: Thu, 7 Mar 2024 10:02:20 +0800 [thread overview]
Message-ID: <1096418c-7657-4d38-8344-bf6cf3c1b8bb@linux.alibaba.com> (raw)
In-Reply-To: <b3601f0d-c315-4763-bbab-4174fe0af713@kernel.org>
On 2024/3/7 09:07, Chao Yu wrote:
> On 2024/3/6 14:51, Gao Xiang wrote:
>>
>>
>> On 2024/3/6 13:31, Gao Xiang wrote:
>>> There are mainly two reasons that thp_get_unmapped_area() should be
>>> used for EROFS as other filesystems:
>>>
>>> - It's needed to enable PMD mappings as a FSDAX filesystem, see
>>> commit 74d2fad1334d ("thp, dax: add thp_get_unmapped_area for pmd
>>> mappings");
>>>
>>> - It's useful together with CONFIG_READ_ONLY_THP_FOR_FS which enables
>>> THPs for read-only mmapped files (e.g. shared libraries) even without
>>> FSDAX. See commit 1854bc6e2420 ("mm/readahead: Align file mappings
>>> for non-DAX").
>>
>> Refine this part as
>>
>> - It's useful together with large folios and CONFIG_READ_ONLY_THP_FOR_FS
>> which enable THPs for mmapped files (e.g. shared libraries) even without
>> ...
>>
>>>
>>> Fixes: 06252e9ce05b ("erofs: dax support for non-tailpacking regular file")
>>
>> Fixes: ce529cc25b18 ("erofs: enable large folios for iomap mode")
>> Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
>>
>>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>
> Reviewed-by: Chao Yu <chao@kernel.org>
Thanks, added!
Thanks,
Gao Xiang
>
> Thanks,
prev parent reply other threads:[~2024-03-07 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 5:31 [PATCH] erofs: apply proper VMA alignment for memory mapped files on THP Gao Xiang
2024-03-06 6:51 ` Gao Xiang
2024-03-06 7:55 ` Jingbo Xu
2024-03-07 1:07 ` Chao Yu
2024-03-07 2:02 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096418c-7657-4d38-8344-bf6cf3c1b8bb@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).