linux-embedded.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: "Lambrecht Jürgen" <J.Lambrecht@TELEVIC.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-embedded@vger.kernel.org" <linux-embedded@vger.kernel.org>
Subject: Re: [PATCH] net: phy: Add config option to specify external switch port to be used if switch is used as PHY
Date: Thu, 8 Sep 2011 23:24:30 +0200	[thread overview]
Message-ID: <20110908212430.GA27980@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <4E68AE26.5020707@televic.com>

Lambrecht Jürgen <J.Lambrecht@TELEVIC.com> :
> On 09/08/2011 12:13 PM, Francois Romieu wrote:
[...]
> > Which driver(s) do you use that you can not set phy_mask directly ?
> >
> The HW driver is 'FEC' for iMX Ethernet. For the PHY, just MII and PHYLIB.
> I am rather new to linux, didn't knew phy_mask. Checked it now, and is 
> not set in fec.c.
> You mean then to patch drivers/net/fec.c in the same way (as my current 
> patch) to set the phy_mask instead (via menuconfig, or in the platform 
> init)?

It is not my area but I would have drivers/net/fec.c::fec_devtype.driver_data
point to a real struct where the relevant phy_mask and the current quirks
are stored, then add a new entry in fec_devtype and a reference to it
(Kconfig + platform init) somewhere below arch/arm/plat-mxc.

Freescale's application note suggests that the MX25 fec allows some freedom
for the implementation of the media interface. So it may not be overkill.

-- 
Ueimor

      reply	other threads:[~2011-09-08 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08  6:54 [PATCH] net: phy: Add config option to specify external switch port to be used if switch is used as PHY Lambrecht Jürgen
2011-09-08  8:39 ` Florian Fainelli
2011-09-08 10:00   ` Lambrecht Jürgen
2011-09-08 10:13 ` Francois Romieu
2011-09-08 11:59   ` Lambrecht Jürgen
2011-09-08 21:24     ` Francois Romieu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110908212430.GA27980@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=J.Lambrecht@TELEVIC.com \
    --cc=linux-embedded@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).