linux-embedded.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: Phillip Lougher <phillip.lougher@gmail.com>,
	Phillip Lougher <phillip@squashfs.org.uk>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-embedded@vger.kernel.org
Subject: Re: [PATCH 0/2] Squashfs: add LZ4 compression
Date: Fri, 26 Jul 2013 17:00:53 -0500	[thread overview]
Message-ID: <1374876053.3031.19@driftwood> (raw)
In-Reply-To: <51ECCB8B.7030104@cn.fujitsu.com> (from guz.fnst@cn.fujitsu.com on Mon Jul 22 01:04:59 2013)

On 07/22/2013 01:04:59 AM, Gu Zheng wrote:
> On 07/22/2013 01:07 PM, Phillip Lougher wrote:
> 
> > On 22 July 2013 04:05, Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:
> >> Hi Phillip,
> >>         Have some tests been carried out to confirm that Squashfs  
> really
> >> can get benefit from LZ4 compression, comparing with lzo?
> >
> > This seems to be a loaded question, in that it seems to be trying to
> > reopen the "why add lz4 when we already have lzo" debate all over
> > again.  As LZ4 has been merged to mainline, this appears to be a
> > question that has already been answered.
> 
> No, they are different. LZ4 can be merged to mainline, because we can
> see the benefit(faster compressing speed under the enabled unaligned
> memory access) it brings to us comparing with lzo.
> But it's hard to say that it also really can bring benefit to  
> Squashfs.

A compression format was added to the kernel. Philip hooked up the code  
that was already in the kernel to a filesystem that was already in the  
kernel.

You consider this action controversial...

Rob

      parent reply	other threads:[~2013-07-26 22:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22  2:21 [PATCH 0/2] Squashfs: add LZ4 compression Phillip Lougher
2013-07-22  2:21 ` [PATCH 1/2] Squashfs: add LZ4 compression support Phillip Lougher
2013-07-22  4:35   ` Joe Perches
2013-07-22  2:21 ` [PATCH 2/2] Squashfs: Add LZ4 compression configuration option Phillip Lougher
2013-07-22  3:05 ` [PATCH 0/2] Squashfs: add LZ4 compression Gu Zheng
2013-07-22  5:07   ` Phillip Lougher
2013-07-22  6:04     ` Gu Zheng
2013-07-22 13:38       ` Phillip Lougher
2013-07-26 22:00       ` Rob Landley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374876053.3031.19@driftwood \
    --to=rob@landley.net \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=linux-embedded@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip.lougher@gmail.com \
    --cc=phillip@squashfs.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).