From: Ira Weiny <ira.weiny@intel.com>
To: Ira Weiny <ira.weiny@intel.com>,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER events
Date: Wed, 1 Nov 2023 14:59:01 -0700 [thread overview]
Message-ID: <6542ca25d2fb7_435c1294aa@iweiny-mobl.notmuch> (raw)
In-Reply-To: <6541c795e39b_2e75b294e0@iweiny-mobl.notmuch>
Ira Weiny wrote:
> Smita Koralahalli wrote:
>
[snip]
> > I think we should copy into each
> > field of struct cxl_event_record_hdr individually starting from length
> > by pointer arithmetic (which is definitely bad, but I cannot think of a
> > better way to do this) and then do memcpy for data field in struct
> > cxl_event_record_raw..
> >
> > Any other suggestions would be helpful as well.
>
> Based on Dan's suggestion to share the structures this memcpy can be
> avoided altogether. Let's see how that works.
memcpy was removed.
>
> >
> > I can make these changes and validate it on my end if that works..?
>
> Any testing would be welcome. I don't have a test setup readily
> available.
Sorry this took so long but I have a new series with the
headers/structures re-aranged along with the other changes.
https://lore.kernel.org/all/20230601-cxl-cper-v3-0-0189d61f7956@intel.com/
Thanks,
Ira
prev parent reply other threads:[~2023-11-01 22:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 18:21 [PATCH RFC v2 0/3] efi/cxl-cper: Report CPER CXL component events through trace events Ira Weiny
2023-10-26 18:21 ` [PATCH RFC v2 1/3] cxl/trace: Remove uuid from event trace known events Ira Weiny
2023-10-26 20:55 ` Dan Williams
2023-10-30 16:58 ` Davidlohr Bueso
2023-10-26 18:21 ` [PATCH RFC v2 2/3] firmware/efi: Process CXL Component Events Ira Weiny
2023-10-26 21:02 ` Dan Williams
2023-10-31 16:46 ` Ira Weiny
2023-10-26 18:21 ` [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER events Ira Weiny
2023-10-26 22:56 ` Dan Williams
2023-10-31 17:13 ` Ira Weiny
2023-11-01 17:35 ` Jonathan Cameron
2023-10-30 21:03 ` Smita Koralahalli
2023-10-30 22:02 ` Dan Williams
2023-11-01 3:35 ` Ira Weiny
2023-11-01 21:59 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6542ca25d2fb7_435c1294aa@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).